Skip to content

Add new GZIP DEFLATE decompressor/compressor#850

Merged
gheskett merged 1 commit intoHackerN64:develop/2.4.0from
aglab2:gzip-rework
Jul 2, 2025
Merged

Add new GZIP DEFLATE decompressor/compressor#850
gheskett merged 1 commit intoHackerN64:develop/2.4.0from
aglab2:gzip-rework

Conversation

@aglab2
Copy link
Collaborator

@aglab2 aglab2 commented Dec 29, 2024

Replaced GZIP DEFLATE decompression algorithm from libdeflate instead of ancient libz implementation. It roughly doubles decompression performance while being smaller.

image
image

File sizes:
6869784 sm64_deflate_new.z64
6876360 sm64_deflate_old.z64

@gheskett gheskett added enhancement New feature or request performance Issue or feature related to game performance labels Jan 19, 2025
@gheskett gheskett added this to the 2.4 milestone Jan 19, 2025
Copy link
Collaborator

@gheskett gheskett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we're now unconditionally adding gzip to the builds, even when using a non-gzip compression format by default?

@aglab2
Copy link
Collaborator Author

aglab2 commented Feb 16, 2025

Any reason we're now unconditionally adding gzip to the builds, even when using a non-gzip compression format by default?

I suggest compression code massacre to remove all unrelated stuff. We build lots of tools for other compression algos as well.

@arthurtilly
Copy link
Collaborator

@gheskett What is the requested change here

@gheskett
Copy link
Collaborator

@gheskett What is the requested change here

The funny debug snippet and merge conflict

@aglab2
Copy link
Collaborator Author

aglab2 commented Jun 21, 2025

Merge conflicts were fixed, ready for another round of review

@gheskett gheskett moved this from In progress to Needs Review in 2.4 (Minor Feature Update) Jun 21, 2025
@gheskett gheskett merged commit 39d0ccb into HackerN64:develop/2.4.0 Jul 2, 2025
@github-project-automation github-project-automation bot moved this from Needs Review to Done in 2.4 (Minor Feature Update) Jul 2, 2025
@aglab2 aglab2 deleted the gzip-rework branch July 2, 2025 04:38
KazeEmanuar

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request performance Issue or feature related to game performance

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants