Skip to content

InputGuard #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HadrienG2 merged 9 commits into from
Jan 29, 2025
Merged

InputGuard #37

HadrienG2 merged 9 commits into from
Jan 29, 2025

Conversation

@crop2000
Copy link
Contributor

@crop2000 crop2000 commented Jan 17, 2025

PR for issue #36 .

@semanticdiff-com
Copy link

semanticdiff-com bot commented Jan 17, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  src/lib.rs  2% smaller
  benches/benchmarks.rs  0% smaller

@HadrienG2 HadrienG2 mentioned this pull request Jan 21, 2025
Closed
@crop2000
fix type and function name for Guard
50bdbe5 
use Input interface in InputPublishGuard
@crop2000 crop2000 marked this pull request as ready for review January 23, 2025 05:26
HadrienG2
HadrienG2 requested changes Jan 23, 2025
View reviewed changes
Copy link
Owner

@HadrienG2 HadrienG2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience, I think we're getting close!

crop2000 and others added 4 commits January 28, 2025 08:50
@crop2000
Copy link
Contributor Author

crop2000 commented Jan 28, 2025

@HadrienG2 i basically just followed your suggestions.

@HadrienG2 HadrienG2 enabled auto-merge January 29, 2025 08:11
@HadrienG2 HadrienG2 merged commit e9cb738 into HadrienG2:main Jan 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HadrienG2 HadrienG2 HadrienG2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crop2000 @HadrienG2