Skip to content

Cleanup references to carthage.vm#137

Open
srak289 wants to merge 1 commit intomasterfrom
srak/internal-vm-reference-cleanup
Open

Cleanup references to carthage.vm#137
srak289 wants to merge 1 commit intomasterfrom
srak/internal-vm-reference-cleanup

Conversation

@srak289
Copy link
Contributor

@srak289 srak289 commented Feb 9, 2026

No description provided.

@srak289 srak289 force-pushed the srak/internal-vm-reference-cleanup branch from 461fdc9 to 6f33c7f Compare February 9, 2026 19:17
@hartmans
Copy link
Member

@srak289 I think that at least the tests need to enable the libvirt plugin. to succeed.

@srak289
Copy link
Contributor Author

srak289 commented Feb 11, 2026

I'm not very familiar with how the tests are architected; should I move tests/test_vm.py to tests/test_libvirt.py ?
Looking through tests I'm not exactly sure where it would be appropriate to enable the libvirt plugin.

@hartmans
Copy link
Member

Renaming to test_libvirt sounds good, although note you'd need to update github workflows.
Best activation would probably be to create a session scope fixture enable_libvirt_plugin in conftest.py and use that fixture in vm_image in conftest.py and the ainjector fixture in test_vm.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants