constructor parameter migrations / unused removal

Author: Haehnchen

src/dict/candlestick.ts

@@ -1,19 +1,12 @@
 export class Candlestick {
-  time: number;
-  open: number;
-  high: number;
-  low: number;
-  close: number;
-  volume: number;
-
-  constructor(time: number, open: number, high: number, low: number, close: number, volume: number) {
-    this.time = time;
-    this.open = open;
-    this.high = high;
-    this.low = low;
-    this.close = close;
-    this.volume = volume;
-  }
+  constructor(
+    public time: number,
+    public open: number,
+    public high: number,
+    public low: number,
+    public close: number,
+    public volume: number
+  ) {}
 
   getArray(): { time: number; open: number; high: number; low: number; close: number; volume: number } {
     return {

src/dict/exchange_candlestick.ts

@@ -8,26 +8,16 @@ export interface CandlestickLike {
 }
 
 export class ExchangeCandlestick {
-  exchange: string;
-  period: string;
-  symbol: string;
-  time: number;
-  open: number;
-  high: number;
-  low: number;
-  close: number;
-  volume: number;
-
   constructor(
-    exchange: string,
-    symbol: string,
-    period: string,
-    time: number,
-    open: number,
-    high: number,
-    low: number,
-    close: number,
-    volume: number
+    public exchange: string,
+    public symbol: string,
+    public period: string,
+    public time: number,
+    public open: number,
+    public high: number,
+    public low: number,
+    public close: number,
+    public volume: number
   ) {
     if (!['m', 'h', 'd', 'y'].includes(period.slice(-1))) {
       throw `Invalid candlestick period: ${period} - ${JSON.stringify(Object.values(arguments))}`;
@@ -38,16 +28,6 @@ export class ExchangeCandlestick {
     if (time <= 631148400) {
       throw `Invalid candlestick time given: ${time} - ${JSON.stringify(Object.values(arguments))}`;
     }
-
-    this.exchange = exchange;
-    this.period = period;
-    this.symbol = symbol;
-    this.time = time;
-    this.open = open;
-    this.high = high;
-    this.low = low;
-    this.close = close;
-    this.volume = volume;
   }
 
   static createFromCandle(exchange: string, symbol: string, period: string, candle: CandlestickLike): ExchangeCandlestick {

src/dict/exchange_order.ts

@@ -28,33 +28,25 @@ export class ExchangeOrder {
   static readonly SIDE_SHORT: ExchangeOrderSideLongShort = 'short';
   static readonly SIDE_LONG: ExchangeOrderSideLongShort = 'long';
 
-  id: string | number;
-  symbol: string;
-  status: ExchangeOrderStatus;
-  price: number;
-  amount: number;
-  retry: boolean;
-  ourId: string | number | undefined;
   side: ExchangeOrderSide;
   type: ExchangeOrderType;
   createdAt: Date;
   updatedAt: Date;
-  raw?: any;
   options: ExchangeOrderOptions;
 
   constructor(
-    id: string | number,
-    symbol: string,
-    status: ExchangeOrderStatus,
-    price: number,
-    amount: number,
-    retry: boolean,
-    ourId?: string | number,
+    public id: string | number,
+    public symbol: string,
+    public status: ExchangeOrderStatus,
+    public price: number,
+    public amount: number,
+    public retry: boolean,
+    public ourId?: string | number,
     side?: ExchangeOrderSide,
     type?: ExchangeOrderType,
     createdAt?: Date,
     updatedAt?: Date,
-    raw?: any,
+    public raw?: any,
     options: ExchangeOrderOptions = {}
   ) {
     if (side && side !== 'buy' && side !== 'sell') {
@@ -75,18 +67,10 @@ export class ExchangeOrder {
       throw `Invalid order type: ${type}`;
     }
 
-    this.id = id;
-    this.symbol = symbol;
-    this.status = status;
-    this.price = price;
-    this.amount = amount;
-    this.retry = retry;
-    this.ourId = ourId;
     this.side = side || 'buy';
     this.type = type || 'unknown';
     this.createdAt = createdAt || new Date();
     this.updatedAt = updatedAt || new Date();
-    this.raw = raw;
     this.options = options;
   }
 

src/dict/exchange_position.ts

@@ -1,16 +1,13 @@
 import { Position } from './position';
 
 export class ExchangePosition {
-  private readonly _exchange: string;
-  private readonly _position: Position;
-
-  constructor(exchange: string, position: Position) {
-    if (!(position instanceof Position)) {
+  constructor(
+    private readonly _exchange: string,
+    private readonly _position: Position
+  ) {
+    if (!(_position instanceof Position)) {
       throw new Error(`TypeError: invalid position`);
     }
-
-    this._exchange = exchange;
-    this._position = position;
   }
 
   getKey(): string {

src/dict/order.ts

@@ -24,26 +24,18 @@ export class Order {
 
   static readonly OPTION_POST_ONLY = 'post_only';
 
-  id: string | number;
-  symbol: string;
-  side: OrderSide;
-  price: number;
-  amount: number;
-  type: OrderType;
-  options: OrderOptions;
-
-  constructor(id: string | number, symbol: string, side: OrderSide, price: number, amount: number, type: OrderType, options: OrderOptions = {}) {
+  constructor(
+    public id: string | number,
+    public symbol: string,
+    public side: OrderSide,
+    public price: number,
+    public amount: number,
+    public type: OrderType,
+    public options: OrderOptions = {}
+  ) {
     if (![Order.SIDE_LONG, Order.SIDE_SHORT].includes(side)) {
       throw new Error(`Invalid order side given: ${side}`);
     }
-
-    this.id = id;
-    this.symbol = symbol;
-    this.side = side;
-    this.price = price;
-    this.amount = amount;
-    this.type = type;
-    this.options = options;
   }
 
   hasAdjustedPrice(): boolean {

src/dict/orderbook.ts

@@ -4,11 +4,5 @@ export interface OrderbookLevel {
 }
 
 export class Orderbook {
-  asks: OrderbookLevel[];
-  bids: OrderbookLevel[];
-
-  constructor(asks: OrderbookLevel[], bids: OrderbookLevel[]) {
-    this.asks = asks;
-    this.bids = bids;
-  }
+  constructor(public asks: OrderbookLevel[], public bids: OrderbookLevel[]) {}
 }

src/dict/pair_state.ts

@@ -13,16 +13,10 @@ export class PairState {
   static readonly STATE_CANCEL: PairStateType = 'cancel';
 
   time: Date;
-  exchange: string;
-  symbol: string;
-  state: PairStateType;
-  options?: any;
   capital?: OrderCapital;
   order?: Order;
   exchangeOrder?: ExchangeOrder;
   retries: number;
-  adjustedPrice: boolean;
-  clearCallback: ClearCallback;
   cleared: boolean;
 
   /**
@@ -78,12 +72,12 @@ export class PairState {
   }
 
   constructor(
-    exchange: string,
-    symbol: string,
-    state: PairStateType,
-    options?: any,
-    adjustedPrice: boolean = false,
-    clearCallback: ClearCallback = () => {}
+    public exchange: string,
+    public symbol: string,
+    public state: PairStateType,
+    public options?: any,
+    public adjustedPrice: boolean = false,
+    public clearCallback: ClearCallback = () => {}
   ) {
     if (![PairState.STATE_LONG, PairState.STATE_SHORT, PairState.STATE_CLOSE, PairState.STATE_CANCEL].includes(state)) {
       throw new Error(`Invalidate state: ${state}`);
@@ -94,15 +88,7 @@ export class PairState {
     }
 
     this.time = new Date();
-    this.exchange = exchange;
-    this.symbol = symbol;
-    this.state = state;
-    this.options = options;
-    this.order = undefined;
-    this.exchangeOrder = undefined;
     this.retries = 0;
-    this.adjustedPrice = adjustedPrice;
-    this.clearCallback = clearCallback;
     this.cleared = false;
   }
 

src/dict/period.ts

@@ -1,7 +1,3 @@
 export class Period {
-  time: any; // lookbacks - keeping any for now since type is unclear
-
-  constructor(lookbacks: any) {
-    this.time = lookbacks;
-  }
+  constructor(public time: any) {} // lookbacks - keeping any for now since type is unclear
 }

src/dict/position.ts

@@ -4,15 +4,6 @@ export class Position {
   static readonly SIDE_LONG: PositionSide = 'long';
   static readonly SIDE_SHORT: PositionSide = 'short';
 
-  symbol: string;
-  side: PositionSide;
-  amount: number;
-  profit: number;
-  updatedAt: Date;
-  entry: number;
-  createdAt: Date;
-  raw?: any;
-
   /**
    * @param symbol 'BTCUSD'
    * @param side "long" or "short"
@@ -23,7 +14,16 @@ export class Position {
    * @param createdAt
    * @param raw
    */
-  constructor(symbol: string, side: PositionSide, amount: number, profit: number, updatedAt: Date, entry: number, createdAt: Date, raw?: any) {
+  constructor(
+    public symbol: string,
+    public side: PositionSide,
+    public amount: number,
+    public profit: number,
+    public updatedAt: Date,
+    public entry: number,
+    public createdAt: Date,
+    public raw?: any
+  ) {
     if (![Position.SIDE_LONG, Position.SIDE_SHORT].includes(side)) {
       throw new Error(`Invalid position direction given:${side}`);
     }
@@ -35,15 +35,6 @@ export class Position {
     if (amount > 0 && side === Position.SIDE_SHORT) {
       throw new Error(`Invalid direction amount:${side}`);
     }
-
-    this.symbol = symbol;
-    this.side = side;
-    this.amount = amount;
-    this.profit = profit;
-    this.updatedAt = updatedAt;
-    this.entry = entry;
-    this.createdAt = createdAt;
-    this.raw = raw;
   }
 
   getSide(): PositionSide {

src/dict/signal.ts

@@ -1,15 +1,9 @@
 export class Signal {
-  id: string;
-  exchange: string;
-  symbol: string;
-  side: string;
-  income_at: number;
-
-  constructor(id: string, exchange: string, symbol: string, side: string, income_at: number) {
-    this.id = id;
-    this.exchange = exchange;
-    this.symbol = symbol;
-    this.side = side;
-    this.income_at = income_at;
-  }
+  constructor(
+    public id: string,
+    public exchange: string,
+    public symbol: string,
+    public side: string,
+    public income_at: number
+  ) {}
 }