Conversation
Member
tazlin
commented
Dec 20, 2025
tazlin
commented
- See feat: Support for Z-image turbo #410 for more information
The root cause was `comfyui_layerdiffusion.lib_layerdiffusion.attentionsharing.forward` being called from `comfy.ldm.modules.attention.forward` via `n = self.attn1(n, context=context_attn1, value=value_attn1, transformer_options=transformer_options)` which included the `transformer_options` argument - which layerdiffusion did not original account for. The change allows the function to accept arbitrary kwargs to avoid the runtime error (of an unexpected argument).
I am assuming this was removed due to the issue noted in the previous commit
This is in direct response to the cascade image to image tests failing due to device tensor mismatches. I've made it a toggle as there are hard to predict implications for the worker, and this should help debug further down the line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.