Skip to content

Fix/poll deadline timeout#63

Open
markniebur wants to merge 2 commits intoHaivision:masterfrom
markniebur:fix/poll-deadline-timeout
Open

Fix/poll deadline timeout#63
markniebur wants to merge 2 commits intoHaivision:masterfrom
markniebur:fix/poll-deadline-timeout

Conversation

@markniebur
Copy link

Fixed a few issues around polling timeouts.

  1. When the poll descriptor is created, it is with a duration of 0, which causes the deadline timer to fire right away and that's waiting the next time a deadline is set up.
  2. If there is a delay between setting up deadlines, and the timer fired after the poll.Wait() had returned, that timer signal is not cleared from the channel and will cause wait to return immediately.
  3. The return value from poll.Wait() is not checked in the Read and Write functions, which will cause a Read to hang if there is no data on the socket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant