Only find boot/data_part if we're building hybris-boot#47
Open
UniversalSuperBox wants to merge 1 commit intoHalium:masterfrom
Open
Only find boot/data_part if we're building hybris-boot#47UniversalSuperBox wants to merge 1 commit intoHalium:masterfrom
UniversalSuperBox wants to merge 1 commit intoHalium:masterfrom
Conversation
hybris-boot has a nasty tendency to throw off the entire build if the fstab and fixup-mountpoints file aren't correct for the current device. This is fine when hybris-boot is the only possible bootimage in the tree, but I expect that we'll have it alongside halium-boot for a little while longer. By putting the partition evaluation and subsequent build error inside the local module's main rule, we keep them from failing the build unless we're actually building hybris-boot. Change-Id: If3ed791d0ba3c11a84d11cef0ea8ef00ab272e9a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hybris-boot has a nasty tendency to throw off the entire build if the
fstab and fixup-mountpoints file aren't correct for the current device.
This is fine when hybris-boot is the only possible bootimage in the
tree, but I expect that we'll have it alongside halium-boot for a little
while longer. By putting the partition evaluation and subsequent build
error inside the local module's main rule, we keep them from failing the
build unless we're actually building hybris-boot.
Change-Id: If3ed791d0ba3c11a84d11cef0ea8ef00ab272e9a