Add support for Stream Deck Neo, Module 6, Module 15, and Module 32#3839
Open
shensquared wants to merge 1 commit intoHammerspoon:masterfrom
Open
Add support for Stream Deck Neo, Module 6, Module 15, and Module 32#3839shensquared wants to merge 1 commit intoHammerspoon:masterfrom
shensquared wants to merge 1 commit intoHammerspoon:masterfrom
Conversation
Add USB Product IDs and device matching for newer Elgato Stream Deck devices: - Stream Deck Neo (0x009A) - 8 keys (4x2), uses Mini class - Stream Deck Module 6 (0x00B8) - 6 keys (3x2), uses Mini class - Stream Deck Module 15 (0x00B9) - 15 keys (5x3), uses MK2 class - Stream Deck Module 32 (0x00BA) - 32 keys (8x4), uses XL class Device PIDs from official Elgato HID documentation: https://docs.elgato.com/streamdeck/hid/
Contributor
|
Awesome! Have you tested this on any real hardware? |
Author
|
Yes, tested on real 15-key Module hardware. Before this change, the device wasn't recognized. Now my existing configs written for older Stream Deck models work correctly on the new hardware. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3839 +/- ##
==========================================
+ Coverage 27.22% 27.31% +0.08%
==========================================
Files 191 191
Lines 51537 51561 +24
==========================================
+ Hits 14032 14082 +50
+ Misses 37505 37479 -26 🚀 New features to boost your workflow:
|
Contributor
|
@cmsj - Not sure why the tests are failing - but are you happy to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add USB Product IDs and device matching for newer Elgato Stream Deck devices:
Device PIDs from official Elgato HID documentation: https://docs.elgato.com/streamdeck/hid/