Deal with robustness for alloca / constant LUTs in DXIL#2389
Draft
HansKristian-Work wants to merge 8 commits intomasterfrom
Draft
Deal with robustness for alloca / constant LUTs in DXIL#2389HansKristian-Work wants to merge 8 commits intomasterfrom
HansKristian-Work wants to merge 8 commits intomasterfrom
Conversation
Owner
Author
|
For testing people, this requires a ton of spot checking across any DXIL based game you can come across. We're interested in game not exploding + any performance regressions you can find. Very minor (~1%) regressions are likely unavoidable. Progress can be reported on this PR for reference. EDIT: When testing, make sure to disable Fossilize layer in Steam, since it's not certain we'll land this. |
f3f1589 to
1c1b2b4
Compare
New bucket since this enables robust alloca/LUT in DXIL. Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
1c1b2b4 to
ff82bfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some tests which explore various cases of UB.