Skip to content

Fix: unpublishable config & demo-theme#161

Open
se09deluca wants to merge 1 commit intoHansSchouten:masterfrom
se09deluca:master
Open

Fix: unpublishable config & demo-theme#161
se09deluca wants to merge 1 commit intoHansSchouten:masterfrom
se09deluca:master

Conversation

@se09deluca
Copy link

@se09deluca se09deluca commented Apr 26, 2024

Currently the configs and demo theme are publishable only if schema has been already migrated.
This PR aims to make the config publishable before the schema migration.

Since the name of database depends on the config, publishing the config before schema migration gives a more linear installation flow.

if (Schema::hasTable(config('pagebuilder.storage.database.prefix').'settings')) {

Related issue:
#155

@Shaz3e
Copy link

Shaz3e commented Jun 22, 2024

This needs to be merged as I cannot run the command to publish the config

php artisan vendor:publish --provider="HansSchouten\LaravelPageBuilder\ServiceProvider" --tag=config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants