Fix: unpublishable config & demo-theme#161
Open
se09deluca wants to merge 1 commit intoHansSchouten:masterfrom
Open
Fix: unpublishable config & demo-theme#161se09deluca wants to merge 1 commit intoHansSchouten:masterfrom
se09deluca wants to merge 1 commit intoHansSchouten:masterfrom
Conversation
|
This needs to be merged as I cannot run the command to publish the config |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the configs and demo theme are publishable only if schema has been already migrated.
This PR aims to make the config publishable before the schema migration.
Since the name of database depends on the config, publishing the config before schema migration gives a more linear installation flow.
Laravel-Pagebuilder/src/ServiceProvider.php
Line 34 in 2689876
Related issue:
#155