[Modding] Fierce Deity Sheaths#1606
Open
Jameriquiah wants to merge 1 commit intoHarbourMasters:developfrom
Open
[Modding] Fierce Deity Sheaths#1606Jameriquiah wants to merge 1 commit intoHarbourMasters:developfrom
Jameriquiah wants to merge 1 commit intoHarbourMasters:developfrom
Conversation
mckinlee
reviewed
Mar 20, 2026
Comment on lines
+17
to
+30
| static bool CustomFDSheath_LoadAssets() { | ||
| if (sFierceDeitySheathState == 0) { | ||
| sFierceDeitySheathState = 1; | ||
|
|
||
| if (ResourceMgr_FileExists(sFierceDeitySwordInSheathDLPath) && | ||
| ResourceMgr_FileExists(sFierceDeitySwordSheathDLPath)) { | ||
| sFierceDeitySwordInSheathDL = ResourceMgr_LoadGfxByName(sFierceDeitySwordInSheathDLPath); | ||
| sFierceDeitySwordSheathDL = ResourceMgr_LoadGfxByName(sFierceDeitySwordSheathDLPath); | ||
| sFierceDeitySheathState = 1; | ||
| } | ||
| } | ||
|
|
||
| return sFierceDeitySheathState == 1; | ||
| } |
Contributor
There was a problem hiding this comment.
What does state 1 mean here? The way its written, both outcomes end up at 1.
Contributor
Author
There was a problem hiding this comment.
just returns and stops it from running every frame, at 0 it checks for if the models exist then stops after, this implementation is kinda broken tho rn i was working on a different way but im at lunch with the wife now, will clean all this up in a bit lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows modders to make sheaths for the FD sword. In
objects/object_link_boy/,gLinkFierceDeitySwordInSheathDLandgLinkFierceDeitySwordSheathDL. If those DL's are detected the game will just load them. So no options or toggles were necessary.Custom Fierce Deity Sheath model ported to this by @nickel246 for testing purposes, posted with permission.
Fierce Deity Sheath.zip
Build Artifacts