Skip to content

Fix Heart Containers/Pieces Item Pool Calculation #6226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serprex merged 3 commits into from
Feb 6, 2026
Merged

Fix Heart Containers/Pieces Item Pool Calculation #6226

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa35afc
Fix calculation for heart pieces/containers to add.
leggettc18 Feb 2, 2026
8221f4f
Fix my math error this time
leggettc18 Feb 3, 2026
41a9a2b
Readd missing break; statement
leggettc18 Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion soh/soh/Enhancements/randomizer/3drando/item_pool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,9 +871,13 @@ void GenerateItemPool() {
break;
case RO_ITEM_POOL_BALANCED: {
int heartsToPlace = maxHearts - startingHearts;
int halfHearts = maxHearts >> 2;
int halfHearts = heartsToPlace / 2;
AddFixedItemToPool(RG_HEART_CONTAINER, heartsToPlace - halfHearts, false);
AddFixedItemToPool(RG_PIECE_OF_HEART, halfHearts * 4, false);
if (halfHearts % 2 == 1) {
// If startingHearts was odd, we only have enough for 19 hearts at this point, add 4 extra heart pieces
AddFixedItemToPool(RG_PIECE_OF_HEART, 4, false);
}
break;
}
case RO_ITEM_POOL_SCARCE:
Expand Down
Loading