Added Android build very wip#490
Draft
izzy2lost wants to merge 127 commits intoHarbourMasters:mainfrom
Draft
Conversation
Contributor
|
I convert the PR to draft like it's wip |
coco875
reviewed
Jul 20, 2025
.github/workflows/main.yml
Outdated
Comment on lines
+395
to
+396
| mkdir -p android/app/src/main/assets/yamls | ||
| cp -r yamls/* android/app/src/main/assets/yamls/ |
Contributor
There was a problem hiding this comment.
hmm it can't be done in the gradle or cmake ?
Open
Contributor
|
Just took a quick glance at this. One tip that would probably help. Is make a separate PR with the game engine related changes (like the memory.c and track file changes). Because most of those changes could likely be merged in without issue, so long as it doesn't break anything else. And then it would likely be easier for you if you're still developing the android side of things. And updating the game code would maybe be easy because there wouldn't be merge conflicts. On one hand, this may be better staying as a fork? Either way is probably fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.