Open
Conversation
coco875
requested changes
Jul 20, 2025
src/code_80057C60.c
Outdated
| case 3: /* switch 1 */ | ||
| if ((D_8018D114 == 0) || (D_8018D114 == 1)) { | ||
|
|
||
| if (*huhthedeuce == 1) { |
Contributor
There was a problem hiding this comment.
maybe just replay the animation of lakitu for each lap to have an animation even if it's incorect
Contributor
Author
There was a problem hiding this comment.
Right now, nothing should happen between the extra laps which is kinda okay. This could be done. I'm not really sure what's best though.
Like do we really want lakitu to say "2nd" lap when it's wrong? Or "Final lap?" when it's wrong?
Contributor
There was a problem hiding this comment.
the best is just lakitu who say next lap. But do how you want
Contributor
Author
There was a problem hiding this comment.
Perhaps a 'next lap' function could be made. And it gets used if a next lap lakitu texture exists?
Contributor
Author
|
As is, I'm not really interested in merging this PR until
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR needs testing and likely has a couple issues.
The array for choosing the Lap 3/3 texture overflows and displays garbage
These arrays need to become dynamic to set any lap amount and have like time trials works
func_800088D8 this also overflows:
temp_a3 = &CM_GetProps()->AIDistance[lapNum * 8];
save.c would also need changes