Skip to content

Update check_sftp.py#375

Open
maxwbot wants to merge 1 commit intoHariSekhon:masterfrom
maxwbot:patch-1
Open

Update check_sftp.py#375
maxwbot wants to merge 1 commit intoHariSekhon:masterfrom
maxwbot:patch-1

Conversation

@maxwbot
Copy link

@maxwbot maxwbot commented Sep 2, 2021

Update for support Password and fix some bugs. Added option to find text in file.

Update for support Password and fix some bugs. Added option to find text in file.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lgtm-com
Copy link

lgtm-com bot commented Sep 2, 2021

This pull request introduces 2 alerts when merging 9029c29 into b577b20 - view on LGTM.com

new alerts:

  • 2 for Unused import

@HariSekhon
Copy link
Owner

HariSekhon commented Sep 2, 2021

What is the use case for using a password instead of SSH Key? Is this less secure?

Also, I generally don't change the date and author headers as that is the origin time of the code, which is an important reference point because it gives a clue as to the code's style based on that time frame, I would write this very differently today.

Tbh if I was still using this code and going to be checking for more things like you're going I'd probably just write a new version of this code with paramiko - there is even a long-standing todo about this at the top of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants