Change run_starlark_code to take additional arguments#3
Open
dcollien wants to merge 2 commits intoHarikrishnanBalagopal:mainfrom
Open
Change run_starlark_code to take additional arguments#3dcollien wants to merge 2 commits intoHarikrishnanBalagopal:mainfrom
dcollien wants to merge 2 commits intoHarikrishnanBalagopal:mainfrom
Conversation
…(string), and all other arguments passed to that function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes run_starlark_code to take in additional arguments:
It's backwards compatible with the original
run_starlark_codewhich only takes a single argument. If given a single argument (just the code), it still runs the main function with no arguments.It also converts any JSON-like arguments to starlark equivalents.
The second commit adds support for returnValue