Fix name of sort attribute key #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriszyp
approved these changes
Aug 11, 2025
Member
|
I don't know where we are in the doc transition; typically we want this on the release_4.5 branch so it applies to 4.5+, but maybe don't need that now. |
Member
|
docs content hasn't been migrated yet so it would need to be applied to each individual branch. if it can wait until after the content migration it could touch all relevant versions in a single pr... |
cb1kenobi
approved these changes
Aug 12, 2025
Member
Author
Yeah, this is not super urgent stuff, so let me know what's easiest for you all w/r/t the platform transition. |
This should be singular, right?
cap10morgan
force-pushed
the
fix/sort-attribute-key
branch
from
eec30d2 to
61d7578
Compare
Ethan-Arrowood
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be singular, right?