Update search conditions properties to new preferred values #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
269
to
271
| - `search_attribute` _(required)_ - the attribute you wish to search, can be any attribute | ||
| - `search_type` _(required)_ - the type of search to perform - `equals`, `contains`, `starts_with`, `ends_with`, `greater_than`, `greater_than_equal`, `less_than`, `less_than_equal`, `between` | ||
| - `search_value` _(required)_ - case-sensitive value you wish to search. If the `search_type` is `between` then use an array of two values to search between | ||
| - `comparator` _(required)_ - the type of search to perform - `equals`, `contains`, `starts_with`, `ends_with`, `greater_than`, `greater_than_equal`, `less_than`, `less_than_equal`, `between` | ||
| - `search_value` _(required)_ - case-sensitive value you wish to search. If the `comparator` is `between` then use an array of two values to search between |
Member
There was a problem hiding this comment.
Should these be updated too?
Member
There was a problem hiding this comment.
Are these fields no longer supported or will they still work on 4.6? Same question for 4.7 and beyond? I assume we are remaining backwards compatible. It may be valuable to include a note somewhere what these fields were previously called in case someone goes searching for them referencing existing code.
search_attribute, search_type, and search_value have been deprecated in favor of attribute, comparator, and value
cap10morgan
force-pushed
the
update/search-condition-properties
branch
from
53b5bae to
2055ca6
Compare
Member
Author
|
@Ethan-Arrowood All should be addressed |
Ethan-Arrowood
approved these changes
Aug 13, 2025
cb1kenobi
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
search_attribute,search_type, andsearch_valuehave been deprecated in favor ofattribute,comparator, andvalue(which have the added bonus of being consistent with the resource API)