-
Notifications
You must be signed in to change notification settings - Fork 9
some protocol fixes #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
some protocol fixes #282
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,7 +54,7 @@ HarperDB/application-template#semver:v1.0.0 | |
| You can also install from private repository if you have installed SSH keys on the server. Ensure the `host` portion of the url exactly matches the `host` used when adding ssh keys to ensure proper authentication. | ||
|
|
||
| ``` | ||
| git+ssh:/[email protected]:my-org/my-app.git#semver:v1.0.0 | ||
| git+ssh://[email protected]:my-org/my-app.git#semver:v1.0.0 | ||
| ``` | ||
|
|
||
| Or you can use a Github token: | ||
|
|
@@ -369,9 +369,9 @@ Host harperdb-private-component.github.com | |
| ``` | ||
|
|
||
| ``` | ||
| "package": "git+ssh:/git@<host>:<github-repo-path>.git#semver:v1.2.3" | ||
| "package": "git+ssh://git@<host>:<github-repo-path>.git#semver:v1.2.3" | ||
|
|
||
| "package": "git+ssh:/[email protected]:HarperDB/harperdb-private-component.git#semver:v1.2.3" | ||
| "package": "git+ssh://[email protected]:HarperDB/harperdb-private-component.git#semver:v1.2.3" | ||
| ``` | ||
|
|
||
| Note that `deploy_component` with a package uses `npm install` so the url must be a valid npm format url. The above is an example of a url using a tag in the repo to install. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -109,7 +109,7 @@ Furthermore, the `package` field can be set to any valid [npm dependency value]( | |
|
|
||
| - For applications deployed to npm, specify the package name: `package="@harperdb/status-check"` | ||
| - For applications on GitHub, specify the URL: `package="https://github.com/HarperDB/status-check"`, or the shorthand `package=HarperDB/status-check` | ||
| - Private repositories also work if the correct SSH keys are on the server: `package="git+ssh:/[email protected]:HarperDB/secret-applications.git"` | ||
| - Private repositories also work if the correct SSH keys are on the server: `package="git+ssh://[email protected]:HarperDB/secret-applications.git"` | ||
| - Reference the [SSH Key](../../../developers/operations-api/components#add-ssh-key) operations for more information on managing SSH keys on a remote instance | ||
| - Even tarball URLs are supported: `package="https://example.com/application.tar.gz"` | ||
|
|
||
|
|
@@ -164,8 +164,8 @@ Harper will generate a `package.json` like: | |
| "dependencies": { | ||
| "myGithubComponent": "github:HarperDB-Add-Ons/package#v2.2.0", | ||
| "myNPMComponent": "npm:harperdb", | ||
| "myTarBall": "file:/Users/harper/cool-component.tar", | ||
| "myLocal": "file:/Users/harper/local", | ||
| "myTarBall": "file://Users/harper/cool-component.tar", | ||
| "myLocal": "file://Users/harper/local", | ||
| "myWebsite": "https://harperdb-component" | ||
| } | ||
| } | ||
|
|
@@ -177,7 +177,7 @@ The package prefix is automatically added, however you can manually set it in yo | |
|
|
||
| ```yaml | ||
| myCoolComponent: | ||
| package: file:/Users/harper/cool-component.tar | ||
| package: file://Users/harper/cool-component.tar | ||
| ``` | ||
|
|
||
| By specifying a file path, npm will generate a symlink and then changes will be automatically picked up between restarts. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,7 +53,7 @@ HarperDB/application-template#semver:v1.0.0 | |
| You can also install from private repository if you have an installed SSH keys on the server: | ||
|
|
||
| ``` | ||
| git+ssh:/[email protected]:my-org/my-app.git#semver:v1.0.0 | ||
| git+ssh://[email protected]:my-org/my-app.git#semver:v1.0.0 | ||
| ``` | ||
|
|
||
| Or you can use a Github token: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.