Skip to content

Conversation

@heskew
Copy link
Member

@heskew heskew commented Oct 2, 2025

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive certificate revocation checking capabilities to Harper's mTLS authentication system. The changes enhance security by allowing certificates to be verified against Certificate Revocation Lists (CRL) and Online Certificate Status Protocol (OCSP) to ensure revoked certificates cannot be used for authentication.

  • Added detailed certificate verification documentation with CRL and OCSP support
  • Updated mTLS authentication documentation to reference the new certificate verification features
  • Enhanced configuration documentation with comprehensive certificate verification settings
  • Restructured security documentation index to better organize authentication and certificate management topics

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
docs/developers/security/mtls-auth.md Added certificate revocation checking section with basic configuration example
docs/developers/security/index.md Restructured navigation to separate authentication, certificate management, and access control
docs/developers/security/certificate-verification.md New comprehensive documentation covering CRL/OCSP verification, configuration, troubleshooting, and best practices
docs/developers/security/certificate-management.md Added certificate revocation checking section explaining CRL and OCSP methods
docs/deployments/configuration.md Updated HTTP and replication configuration sections with detailed certificate verification settings

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@heskew heskew requested review from a team and nenharper October 2, 2025 20:49
Copy link
Member

@kriszyp kriszyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic docs, great work!

This can be enabled to require client certificates (mTLS) for all incoming HTTP connections. If enabled, any connection that doesn't provide an authorized certificate will be rejected/closed. By default, this is disabled, and authentication can take place with mTLS _or_ standard credential authentication.

`certificateVerification` - _Type_: boolean | object; _Default_: true
**Note:** MQTT has its own `mqtt.network.mtls.required` setting. Replication always requires mTLS (cannot be disabled).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secure (wss with a securePort) replication always requires mTLS (non-secure replication can be done by specifying IP addresses).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoot. Right. Good catch. That's confusing and not thorough.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. LMK what you think.

@Ethan-Arrowood Ethan-Arrowood merged commit fbc83aa into main Oct 8, 2025
5 checks passed
@Ethan-Arrowood Ethan-Arrowood deleted the mtls-certverification branch October 8, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants