add ga4 gtag #352
Merged
add ga4 gtag #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I added the secret; not sure why CI failed first run. Checking again before merging to be certain. |
heskew
reviewed
Oct 21, 2025
docusaurus.config.ts
Outdated
Comment on lines
247
to
254
| // GA4 | ||
| [ | ||
| '@docusaurus/plugin-google-gtag', | ||
| { | ||
| trackingID: process.env.GA4_TRACKING_ID || '', | ||
| anonymizeIP: true, | ||
| }, | ||
| ], |
Member
There was a problem hiding this comment.
Suggested change
| // GA4 | |
| [ | |
| '@docusaurus/plugin-google-gtag', | |
| { | |
| trackingID: process.env.GA4_TRACKING_ID || '', | |
| anonymizeIP: true, | |
| }, | |
| ], | |
| // GA4 - only load if tracking ID is set | |
| ...(process.env.GA4_TRACKING_ID | |
| ? [ | |
| [ | |
| '@docusaurus/plugin-google-gtag', | |
| { | |
| trackingID: process.env.GA4_TRACKING_ID, | |
| anonymizeIP: true, | |
| }, | |
| ], | |
| ] | |
| : []), |
This errors when trying to build locally too. Maybe just include if we have the env var?
Member
Might need to add it to the build step? https://github.com/HarperFast/documentation/blob/main/.github/workflows/deploy.yaml#L52 |
Member
Author
|
Ah that is definitely what is missing; thought I pushed that commit. Whoops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.