Conversation
...and the need to even have one at all
For some reason the unit tests stopped working for me today w/o this
...so it doesn't pollute other tests
Use lambdas & remove unnecessary asyncs
The prior approach broke the ability to specify a subset of tests on the command line
It's pretty flaky, but we're working on it
The before hook is failing pretty often
More and better unit tests
...instead of OVERRIDE_HOME_DIR
Ethan-Arrowood
approved these changes
Nov 4, 2025
kriszyp
approved these changes
Nov 4, 2025
Member
kriszyp
left a comment
kriszyp
left a comment
There was a problem hiding this comment.
Stop chickening out on HTTP server options types
😆
Member
Author
|
Let's hold off on merging this until we figure out if we want to revert and redo #15. |
Member
Author
|
Unlikely we'll merge this as-is, but let's leave it open so I don't forget to incorporate some of its ideas when we get back to this stage of migrating unit tests. |
Member
Author
|
Don't think we'll be merging this. I will refer back to the branch as needed to bring fixes into the new approach (in #31), though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses some comments that came in after merging #15.