Use the VM loader for loading plugin modules as well resource modules#209
Merged
Use the VM loader for loading plugin modules as well resource modules#209
Conversation
…pplication that is used for the VM loading and is also used to load plugins within that application
kriszyp
changed the title
cb1kenobi
reviewed
Mar 11, 2026
Co-authored-by: Chris Barber <chris@harperdb.io>
Merged
cb1kenobi
reviewed
Mar 12, 2026
| ); | ||
| } else if (usePrivateGlobal && url.startsWith('file://')) { | ||
| checkAllowedModulePath(url, scope.applicationContainment.verifyPath); | ||
| checkAllowedModulePath(url, scope.verifyPath); |
Contributor
There was a problem hiding this comment.
What if verifyPath is undefined? checkAllowedModulePath() expects containingFolder to be defined, so maybe it's easiest to let checkAllowedModulePath() accept an undefined containingFolder and throw a meaningful message?
Co-authored-by: Chris Barber <chris@cb1inc.com>
DavidCockerill
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates an application scope that uses the VM loading and is used to load plugins within that application as well as resource modules.