Conversation
\ resolves #26
There was a problem hiding this comment.
Pull request overview
This PR resolves #26 by disambiguating the OAuth provider stored on the session when using named provider configurations, separating “provider config key” from “provider type” while preserving backwards compatibility.
Changes:
- Extend session OAuth metadata to include
providerConfigId(config key) andproviderType(provider type), while deprecatingproviderfor the config-key meaning. - Populate the new session fields during OAuth callback handling and return them from the user-info endpoint.
- Update middleware to resolve providers by
providerConfigId(with fallback toprovider) and adjust multi-tenant SSO docs example.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/types.ts | Adds providerConfigId and providerType to OAuthSessionMetadata and deprecates provider for the config-key meaning. |
| src/lib/handlers.ts | Writes the new fields into the session during callback; surfaces them in handleUserInfo. |
| src/index.ts | Uses providerConfigId (fallback to provider) for provider registry lookup and dynamic resolution logging. |
| docs/multi-tenant-sso.md | Updates example to use providerConfigId as the tenant identifier. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #26