-
Notifications
You must be signed in to change notification settings - Fork 0
Reenable unit tests #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable unit tests #302
Conversation
Bumps the patch group with 3 updates in the / directory: [lefthook](https://github.com/evilmartians/lefthook), [tsdown](https://github.com/rolldown/tsdown) and [ast-v8-to-istanbul](https://github.com/AriPerkkio/ast-v8-to-istanbul). Updates `lefthook` from 2.0.12 to 2.0.13 - [Release notes](https://github.com/evilmartians/lefthook/releases) - [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md) - [Commits](evilmartians/lefthook@v2.0.12...v2.0.13) Updates `tsdown` from 0.18.2 to 0.18.3 - [Release notes](https://github.com/rolldown/tsdown/releases) - [Commits](rolldown/tsdown@v0.18.2...v0.18.3) Updates `@rolldown/binding-android-arm64` from 1.0.0-beta.55 to 1.0.0-beta.57 - [Release notes](https://github.com/rolldown/rolldown/releases) - [Changelog](https://github.com/rolldown/rolldown/blob/main/CHANGELOG.md) - [Commits](https://github.com/rolldown/rolldown/commits/v1.0.0-beta.57/packages/rolldown) Updates `@rolldown/binding-darwin-arm64` from 1.0.0-beta.55 to 1.0.0-beta.57 - [Release notes](https://github.com/rolldown/rolldown/releases) - [Changelog](https://github.com/rolldown/rolldown/blob/main/CHANGELOG.md) - [Commits](https://github.com/rolldown/rolldown/commits/v1.0.0-beta.57/packages/rolldown) Updates `@rolldown/binding-darwin-x64` from 1.0.0-beta.55 to 1.0.0-beta.57 - [Release notes](https://github.com/rolldown/rolldown/releases) - [Changelog](https://github.com/rolldown/rolldown/blob/main/CHANGELOG.md) - [Commits](https://github.com/rolldown/rolldown/commits/v1.0.0-beta.57/packages/rolldown) Updates `@rolldown/binding-freebsd-x64` from 1.0.0-beta.55 to 1.0.0-beta.57 - [Release notes](https://github.com/rolldown/rolldown/releases) - [Changelog](https://github.com/rolldown/rolldown/blob/main/CHANGELOG.md) - [Commits](https://github.com/rolldown/rolldown/commits/v1.0.0-beta.57/packages/rolldown) Updates `@rolldown/binding-linux-arm-gnueabihf` from 1.0.0-beta.55 to 1.0.0-beta.57 - [Release notes](https://github.com/rolldown/rolldown/releases) - [Changelog](https://github.com/rolldown/rolldown/blob/main/CHANGELOG.md) - [Commits](https://github.com/rolldown/rolldown/commits/v1.0.0-beta.57/packages/rolldown) Updates `@rolldown/binding-linux-arm64-gnu` from 1.0.0-beta.55 to 1.0.0-beta.57 - [Release notes](https://github.com/rolldown/rolldown/releases) - [Changelog](https://github.com/rolldown/rolldown/blob/main/CHANGELOG.md) - [Commits](https://github.com/rolldown/rolldown/commits/v1.0.0-beta.57/packages/rolldown) Updates `@rolldown/binding-linux-arm64-musl` from 1.0.0-beta.55 to 1.0.0-beta.57 - [Release notes](https://github.com/rolldown/rolldown/releases) - [Changelog](https://github.com/rolldown/rolldown/blob/main/CHANGELOG.md) - [Commits](https://github.com/rolldown/rolldown/commits/v1.0.0-beta.57/packages/rolldown) Updates `@rolldown/binding-linux-x64-gnu` from 1.0.0-beta.55 to 1.0.0-beta.57 - [Release notes](https://github.com/rolldown/rolldown/releases) - [Changelog](https://github.com/rolldown/rolldown/blob/main/CHANGELOG.md) - [Commits](https://github.com/rolldown/rolldown/commits/v1.0.0-beta.57/packages/rolldown) Updates `@rolldown/binding-linux-x64-musl` from 1.0.0-beta.55 to 1.0.0-beta.57 - [Release notes](https://github.com/rolldown/rolldown/releases) - [Changelog](https://github.com/rolldown/rolldown/blob/main/CHANGELOG.md) - [Commits](https://github.com/rolldown/rolldown/commits/v1.0.0-beta.57/packages/rolldown) Updates `@rolldown/binding-openharmony-arm64` from 1.0.0-beta.55 to 1.0.0-beta.57 - [Release notes](https://github.com/rolldown/rolldown/releases) - [Changelog](https://github.com/rolldown/rolldown/blob/main/CHANGELOG.md) - [Commits](https://github.com/rolldown/rolldown/commits/v1.0.0-beta.57/packages/rolldown) Updates `@rolldown/binding-wasm32-wasi` from 1.0.0-beta.55 to 1.0.0-beta.57 - [Release notes](https://github.com/rolldown/rolldown/releases) - [Changelog](https://github.com/rolldown/rolldown/blob/main/CHANGELOG.md) - [Commits](https://github.com/rolldown/rolldown/commits/v1.0.0-beta.57/packages/rolldown) Updates `@rolldown/binding-win32-arm64-msvc` from 1.0.0-beta.55 to 1.0.0-beta.57 - [Release notes](https://github.com/rolldown/rolldown/releases) - [Changelog](https://github.com/rolldown/rolldown/blob/main/CHANGELOG.md) - [Commits](https://github.com/rolldown/rolldown/commits/v1.0.0-beta.57/packages/rolldown) Updates `@rolldown/binding-win32-x64-msvc` from 1.0.0-beta.55 to 1.0.0-beta.57 - [Release notes](https://github.com/rolldown/rolldown/releases) - [Changelog](https://github.com/rolldown/rolldown/blob/main/CHANGELOG.md) - [Commits](https://github.com/rolldown/rolldown/commits/v1.0.0-beta.57/packages/rolldown) Updates `@rolldown/pluginutils` from 1.0.0-beta.55 to 1.0.0-beta.57 - [Release notes](https://github.com/rolldown/rolldown/releases) - [Changelog](https://github.com/rolldown/rolldown/blob/main/CHANGELOG.md) - [Commits](https://github.com/rolldown/rolldown/commits/v1.0.0-beta.57/packages/pluginutils) Updates `ast-v8-to-istanbul` from 0.3.9 to 0.3.10 - [Release notes](https://github.com/AriPerkkio/ast-v8-to-istanbul/releases) - [Commits](AriPerkkio/ast-v8-to-istanbul@v0.3.9...v0.3.10) Updates `lefthook-darwin-arm64` from 2.0.12 to 2.0.13 - [Release notes](https://github.com/evilmartians/lefthook/releases) - [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md) - [Commits](evilmartians/lefthook@v2.0.12...v2.0.13) Updates `lefthook-darwin-x64` from 2.0.12 to 2.0.13 - [Release notes](https://github.com/evilmartians/lefthook/releases) - [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md) - [Commits](evilmartians/lefthook@v2.0.12...v2.0.13) Updates `lefthook-freebsd-arm64` from 2.0.12 to 2.0.13 - [Release notes](https://github.com/evilmartians/lefthook/releases) - [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md) - [Commits](evilmartians/lefthook@v2.0.12...v2.0.13) Updates `lefthook-freebsd-x64` from 2.0.12 to 2.0.13 - [Release notes](https://github.com/evilmartians/lefthook/releases) - [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md) - [Commits](evilmartians/lefthook@v2.0.12...v2.0.13) Updates `lefthook-linux-arm64` from 2.0.12 to 2.0.13 - [Release notes](https://github.com/evilmartians/lefthook/releases) - [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md) - [Commits](evilmartians/lefthook@v2.0.12...v2.0.13) Updates `lefthook-linux-x64` from 2.0.12 to 2.0.13 - [Release notes](https://github.com/evilmartians/lefthook/releases) - [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md) - [Commits](evilmartians/lefthook@v2.0.12...v2.0.13) Updates `lefthook-openbsd-arm64` from 2.0.12 to 2.0.13 - [Release notes](https://github.com/evilmartians/lefthook/releases) - [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md) - [Commits](evilmartians/lefthook@v2.0.12...v2.0.13) Updates `lefthook-openbsd-x64` from 2.0.12 to 2.0.13 - [Release notes](https://github.com/evilmartians/lefthook/releases) - [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md) - [Commits](evilmartians/lefthook@v2.0.12...v2.0.13) Updates `lefthook-windows-arm64` from 2.0.12 to 2.0.13 - [Release notes](https://github.com/evilmartians/lefthook/releases) - [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md) - [Commits](evilmartians/lefthook@v2.0.12...v2.0.13) Updates `lefthook-windows-x64` from 2.0.12 to 2.0.13 - [Release notes](https://github.com/evilmartians/lefthook/releases) - [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md) - [Commits](evilmartians/lefthook@v2.0.12...v2.0.13) Updates `rolldown-plugin-dts` from 0.19.2 to 0.20.0 - [Release notes](https://github.com/sxzz/rolldown-plugin-dts/releases) - [Commits](sxzz/rolldown-plugin-dts@v0.19.2...v0.20.0) Updates `rolldown` from 1.0.0-beta.55 to 1.0.0-beta.57 - [Release notes](https://github.com/rolldown/rolldown/releases) - [Changelog](https://github.com/rolldown/rolldown/blob/main/CHANGELOG.md) - [Commits](https://github.com/rolldown/rolldown/commits/v1.0.0-beta.57/packages/rolldown) Updates `unrun` from 0.2.20 to 0.2.21 - [Release notes](https://github.com/Gugustinette/unrun/releases) - [Commits](Gugustinette/unrun@v0.2.20...v0.2.21) --- updated-dependencies: - dependency-name: lefthook dependency-version: 2.0.13 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: patch - dependency-name: tsdown dependency-version: 0.18.3 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: patch - dependency-name: "@rolldown/binding-android-arm64" dependency-version: 1.0.0-beta.57 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: "@rolldown/binding-darwin-arm64" dependency-version: 1.0.0-beta.57 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: "@rolldown/binding-darwin-x64" dependency-version: 1.0.0-beta.57 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: "@rolldown/binding-freebsd-x64" dependency-version: 1.0.0-beta.57 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: "@rolldown/binding-linux-arm-gnueabihf" dependency-version: 1.0.0-beta.57 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: "@rolldown/binding-linux-arm64-gnu" dependency-version: 1.0.0-beta.57 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: "@rolldown/binding-linux-arm64-musl" dependency-version: 1.0.0-beta.57 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: "@rolldown/binding-linux-x64-gnu" dependency-version: 1.0.0-beta.57 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: "@rolldown/binding-linux-x64-musl" dependency-version: 1.0.0-beta.57 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: "@rolldown/binding-openharmony-arm64" dependency-version: 1.0.0-beta.57 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: "@rolldown/binding-wasm32-wasi" dependency-version: 1.0.0-beta.57 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: "@rolldown/binding-win32-arm64-msvc" dependency-version: 1.0.0-beta.57 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: "@rolldown/binding-win32-x64-msvc" dependency-version: 1.0.0-beta.57 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: "@rolldown/pluginutils" dependency-version: 1.0.0-beta.57 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: ast-v8-to-istanbul dependency-version: 0.3.10 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: lefthook-darwin-arm64 dependency-version: 2.0.13 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: lefthook-darwin-x64 dependency-version: 2.0.13 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: lefthook-freebsd-arm64 dependency-version: 2.0.13 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: lefthook-freebsd-x64 dependency-version: 2.0.13 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: lefthook-linux-arm64 dependency-version: 2.0.13 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: lefthook-linux-x64 dependency-version: 2.0.13 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: lefthook-openbsd-arm64 dependency-version: 2.0.13 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: lefthook-openbsd-x64 dependency-version: 2.0.13 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: lefthook-windows-arm64 dependency-version: 2.0.13 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: lefthook-windows-x64 dependency-version: 2.0.13 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: rolldown-plugin-dts dependency-version: 0.20.0 dependency-type: indirect update-type: version-update:semver-minor dependency-group: patch - dependency-name: rolldown dependency-version: 1.0.0-beta.57 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch - dependency-name: unrun dependency-version: 0.2.21 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps the patch group with 2 updates: [tsdown](https://github.com/rolldown/tsdown) and [@napi-rs/wasm-runtime](https://github.com/napi-rs/napi-rs/tree/HEAD/wasi-runtime). Updates `tsdown` from 0.18.3 to 0.18.4 - [Release notes](https://github.com/rolldown/tsdown/releases) - [Commits](rolldown/tsdown@v0.18.3...v0.18.4) Updates `@napi-rs/wasm-runtime` from 1.1.0 to 1.1.1 - [Release notes](https://github.com/napi-rs/napi-rs/releases) - [Commits](https://github.com/napi-rs/napi-rs/commits/@napi-rs/[email protected]/wasi-runtime) --- updated-dependencies: - dependency-name: tsdown dependency-version: 0.18.4 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: patch - dependency-name: "@napi-rs/wasm-runtime" dependency-version: 1.1.1 dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [oxlint](https://github.com/oxc-project/oxc/tree/HEAD/npm/oxlint) from 1.35.0 to 1.36.0. - [Release notes](https://github.com/oxc-project/oxc/releases) - [Changelog](https://github.com/oxc-project/oxc/blob/main/npm/oxlint/CHANGELOG.md) - [Commits](https://github.com/oxc-project/oxc/commits/oxlint_v1.36.0/npm/oxlint) --- updated-dependencies: - dependency-name: oxlint dependency-version: 1.36.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…ate if commit fails
📊 Benchmark Resultsencoding.bench.tsKey encoding > ordered-binary keys - strings (100 records)
Key encoding > ordered-binary keys - numbers (100 records)
Key encoding > ordered-binary keys - mixed types (100 records)
Value encoding > msgpack values - strings (100 records)
Value encoding > msgpack values - numbers (100 records)
Value encoding > msgpack values - arrays (100 records)
Value encoding > msgpack values - small objects (100 records)
Value encoding > msgpack values - large objects (100 records)
get-sync.bench.tsgetSync() > random keys - small key size (100 records)
get.bench.tsget() > rocksdb - random vs sequential keys (100 records)
get() > random keys - max 1978 lmdb key size (100 records)
get() > rocksdb - async vs sync
put-sync.bench.tsputSync() > random keys - insert - small key size (100 records)
putSync() > random keys - update - small key size (100 records)
putSync() > random keys - insert - max 1978 lmdb key size (100 records)
putSync() > random keys - update - max 1978 lmdb key size (100 records)
putSync() > sequential keys - insert (100 records)
putSync() > put 100KB value (100 records)
putSync() > put 1MB value (100 records)
putSync() > get 10MB value (100 records)
put.bench.tsput > small dataset (100 records)
put > async vs sync overhead
ranges.bench.tsgetRange() > small range (100 records, 50 range)
getRange() > full scan vs range scan
getKeys() > keys only (100 records, 50 range)
Reverse iteration > reverse range (100 records, 50 range)
Reverse iteration > rocksdb - reverse vs forward
Range query patterns > prefix scan performance
Sparse data patterns > sparse - range over gaps
Sparse data patterns > sparse - prefix with gaps
remove-sync.bench.tsremoveSync() > random keys - small key size (100 records)
removeSync() > sequential keys - small key size (100 records)
removeSync() > rocksdb - random vs sequential keys (100 records)
removeSync() > random keys - max 1978 lmdb key size (100 records)
removeSync() > random access pattern (100 records)
removeSync() > non-existent keys (100 records)
transaction-log.bench.tsTransaction log > write log with 100 byte records
Transaction log > read 100 iterators while write log with 100 byte records
Transaction log > read one entry from random position from log with 1000 100 byte records
transaction-sync.bench.tstransaction sync > optimistic > simple put operations (100 records)
transaction sync > optimistic > batch operations (100 records)
transaction sync > optimistic > read-write operations (100 records)
transaction sync > optimistic > concurrent non-conflicting operations (100 records)
transaction sync > optimistic > rollback operations (100 records)
transaction sync > optimistic > rocksdb - large transaction vs many small
transaction sync > optimistic > lmdb - large transaction vs many small
transaction sync > optimistic > empty transaction overhead
transaction sync > optimistic > transaction with only reads (100 records)
transaction sync > pessimistic > simple put operations (100 records)
transaction.bench.tstransaction > optimistic > simple put operations (100 records)
transaction > optimistic > batch operations (100 records)
transaction > optimistic > read-write operations (100 records)
transaction > optimistic > concurrent non-conflicting operations (100 records)
transaction > optimistic > rollback operations (100 records)
transaction > optimistic > rocksdb - large transaction vs many small
transaction > optimistic > lmdb - large transaction vs many small
transaction > optimistic > empty transaction overhead
transaction > optimistic > transaction with only reads (100 records)
transaction > pessimistic > simple put operations (100 records)
worker-get-sync.bench.tsWorker > random keys - small key size (100 records, 1 worker)
Worker > random keys - small key size (100 records, 2 workers)
Worker > random keys - small key size (100 records, 10 workers)
worker-put-sync.bench.tsputSync() > random keys - small key size (100 records, 1 worker)
putSync() > random keys - small key size (100 records, 2 workers)
putSync() > random keys - small key size (100 records, 10 workers)
worker-transaction-log.bench.tsTransaction log with workers > write log with 100 byte records
Results from commit f58b446 |
kriszyp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase this on top of reenable-unit-tests? If this is intended to supercede it, I kinda need to see the diff, which is really hard with parallel branches.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
| let latestLogId = loadLastPosition(); | ||
| let latestSize = size; | ||
| if (latestLogId > logBuffer.logId) { | ||
| const { logId: latestLogId, size: latestSize } = loadLastPosition(transactionLog, !!readUncommitted); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think loadLastPosition returns a number.
| if (logBuffer?.logId !== logId) { | ||
| // if the current log buffer is not the one we want, load the memory map | ||
| logBuffer = getLogMemoryMap(logId)!; | ||
| logBuffer = getLogMemoryMap(this, logId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this is call getLogMemoryMap with two arguments, but it only takes one.
kriszyp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
getLogFileSize(0)testtransaction-optimistic.test.tstestnapi_adjust_external_memorycallsSupersedes #291.