Skip to content

feat: Allow cleaning up orphan blobs from databases on instances#1152

Merged
dawsontoth merged 1 commit intostagefrom
orphan-blobs
Mar 30, 2026
Merged

feat: Allow cleaning up orphan blobs from databases on instances#1152
dawsontoth merged 1 commit intostagefrom
orphan-blobs

Conversation

@dawsontoth
Copy link
Copy Markdown
Contributor

No description provided.

@dawsontoth dawsontoth requested a review from a team as a code owner March 23, 2026 14:09
Copy link
Copy Markdown
Member

@kriszyp kriszyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we put this in the admin interface? It seems weird to expect users to fix our bugs.

@dawsontoth
Copy link
Copy Markdown
Contributor Author

@kriszyp do you mean we should only show this to users when they're harper admins?

@dawsontoth
Copy link
Copy Markdown
Contributor Author

@kriszyp I restricted it.

@dawsontoth dawsontoth requested a review from kriszyp March 24, 2026 16:27
Copy link
Copy Markdown
Member

@kriszyp kriszyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And you think it is appropriate that it is part of this UI versus the admin interface? (that will be a different interface, right?) I guess I was expecting that this would be part of our administrative UI. If this is the appropriate place, I'm fine with this, but wanted to make sure this in the right workflow.

@Devin-Holland
Copy link
Copy Markdown
Member

And you think it is appropriate that it is part of this UI versus the admin interface? (that will be a different interface, right?) I guess I was expecting that this would be part of our administrative UI. If this is the appropriate place, I'm fine with this, but wanted to make sure this in the right workflow.

I think we should be able to jump from the Admin UI to instances/clusters/orgs (since we can access them all anyway) and then click the button for the specific instance. But maybe we can also have a shortcut to this in the admin panel as well?

@dawsontoth
Copy link
Copy Markdown
Contributor Author

I've been operating under the assumption that various administrative tasks can happen within this interface here. I wasn't planning on creating a separate codebase or website that you navigate to, similar to how we aren't making another copy of central manager to support the administrative functions.

Copy link
Copy Markdown
Member

@kriszyp kriszyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing https://harperdb.atlassian.net/wiki/spaces/SD/pages/490209295/Admin+Page+s, I was assuming that most of this would exist under a different high-level category (sibling to "Organizations" tab?). But there isn't really anything in there that gets to the database level of instances. So I think this probably is the best place for this.

@dawsontoth dawsontoth added this pull request to the merge queue Mar 30, 2026
Merged via the queue into stage with commit 48d63cb Mar 30, 2026
2 checks passed
@dawsontoth dawsontoth deleted the orphan-blobs branch March 30, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants