fix: Load cluster when editing properly #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By switching to using the clusterLayoutRoute, the cluster in the route context will be populated properly.
dawsontoth
force-pushed
the
fix-edit-hanging
branch
from
4784bc8 to
2a22f9e
Compare
|
BboyAkers
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I switched the cluster new/edit form to use the route context params, I didn't notice that the cluster wasn't loading. Which makes sense, because the org layout route didn't know to load it. 🤦 This was resulting in the cluster edit form hanging while it waited dutifully for the cluster's data to load.
By switching to using the clusterLayoutRoute, the cluster in the route context will be populated properly.
To reproduce, try to edit a cluster in stage. I pushed this fix to dev, so go try editing a cluster in dev and it should load up right away.