Open
Conversation
added 2 commits
September 23, 2019 23:28
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=========================================
+ Coverage 88.47% 92.78% +4.3%
=========================================
Files 8 8
Lines 269 291 +22
=========================================
+ Hits 238 270 +32
+ Misses 31 21 -10
Continue to review full report at Codecov.
|
Author
|
it seems the rule of julia> dump(r)
PatternRule
left: Term
ex: Expr
head: Symbol call
args: Array{Any}((2,))
1: exp (function of type typeof(exp))
2: Expr
head: Symbol call
args: Array{Any}((3,))
1: * (function of type typeof(*))
2: Expr
head: Symbol call
args: Array{Any}((3,))
1: * (function of type typeof(*))
2: Int64 2
3: Irrational{:π} π = 3.1415926535897...
3: Complex{Bool}
re: Bool false
im: Bool true
right: Term
ex: Int64 1
ps: Array{Function}((0,))but after |
Author
|
I fixed this by defining it as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
however I find this might be conflict with BASIC rules which evals the pi * im expression, is there a way to treat
Irrationals differently?Update: I changed the
is_constantand printings forIrrational, it looks working now! should fix #81