Skip to content

fix: x and y limits in optical system view#32

Merged
HarrisonKramer merged 1 commit intoHarrisonKramer:masterfrom
edavidfs:bugfix/view_limits
Jan 8, 2025
Merged

fix: x and y limits in optical system view#32
HarrisonKramer merged 1 commit intoHarrisonKramer:masterfrom
edavidfs:bugfix/view_limits

Conversation

@edavidfs
Copy link
Contributor

@edavidfs edavidfs commented Jan 8, 2025

Adding xlim and ylim to a 2D plot did not work because it seems that the plot boundaries were restored.

@codecov
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 98.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
optiland/visualization/visualization.py 95.78% <100.00%> (ø)

@HarrisonKramer
Copy link
Owner

Thanks for fixing this! Will merge now.

@HarrisonKramer HarrisonKramer merged commit 980d84b into HarrisonKramer:master Jan 8, 2025
5 checks passed
@HarrisonKramer
Copy link
Owner

Hi @edavidfs,

By the way, another collaborator set up a discord server for Optiland contributors (or users). The goal is to make it easier to discuss Optiland-related topics/planning. Feel free to join, if you wish:

https://discord.gg/VPrwKR9S

Regards,
Kramer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants