Skip to content

Feat/cs xyz input surface factory#34

Merged
HarrisonKramer merged 12 commits intomasterfrom
feat/cs_xyz_input_surface_factory
Jan 11, 2025
Merged

Feat/cs xyz input surface factory#34
HarrisonKramer merged 12 commits intomasterfrom
feat/cs_xyz_input_surface_factory

Conversation

@HarrisonKramer
Copy link
Owner

  • Add ability to define surface positions by absolute position in global coordinate system.
  • Updates to surface factory to support absolute coordinates

@codecov
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 98.04% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
optiland/optic.py 96.92% <ø> (ø)
optiland/physical_apertures.py 96.42% <100.00%> (+2.14%) ⬆️
optiland/surfaces/surface_factory.py 100.00% <100.00%> (ø)
optiland/surfaces/surface_group.py 96.46% <100.00%> (ø)

@HarrisonKramer HarrisonKramer merged commit d99dc09 into master Jan 11, 2025
4 checks passed
@HarrisonKramer HarrisonKramer deleted the feat/cs_xyz_input_surface_factory branch January 11, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant