Fix Optic.plot_surface_sag kwargs forwarding #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accept and forward fig_to_plot_on, max_extent, num_points_grid, and buffer_factor to SurfaceSagViewer. This restores compatibility with gallery notebooks that call plot_surface_sag(..., max_extent=..., num_points_grid=...).
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #424 +/- ##
=======================================
Coverage 92.27% 92.27%
=======================================
Files 295 295
Lines 17097 17097
=======================================
Hits 15777 15777
Misses 1320 1320
🚀 New features to boost your workflow:
|
Owner
|
Thanks for fixing this, @Xiong-Ziyi! Merging now. Kramer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept and forward fig_to_plot_on, max_extent, num_points_grid, and buffer_factor to SurfaceSagViewer.
This restores compatibility with gallery notebooks that call plot_surface_sag(..., max_extent=..., num_points_grid=...).
Fixes #423