Add Angular Spectrum wave propagation module#486
Draft
gustavu92 wants to merge 1 commit intoHarrisonKramer:masterfrom
Draft
Add Angular Spectrum wave propagation module#486gustavu92 wants to merge 1 commit intoHarrisonKramer:masterfrom
gustavu92 wants to merge 1 commit intoHarrisonKramer:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft – Angular Spectrum Wave Propagation (ASM)
This is an early draft PR to get feedback before continuing the implementation.
It is not the final version. I would like your suggestions on API design and tensor layout before refining and expanding the module.
What is included
optiland.wavepropagationBaseWavePropagatorAngularSpectrumPropagator(ASM implementation)"clamp"and"decay"fftfreq,fft2,ifft2,meshgrid,pad,clamp,broadcast_to,zerosclampzplanes(S, F, W, N, N)The notebook is for clarity and experimentation. It can be simplified or adjusted before moving into
docs/examples.Main Design Question
I am unsure about the expected output layout of
compute_field.Currently I support:
(W, N, N)for a single field(F, W, N, N)for multiple fieldsIn the tutorial, I standardize everything to
(S, F, W, N, N)when stacking over propagation distance.I am not fully convinced this is the best convention.
Questions:
(F, W, N, N)aligned with the rest of Optiland design?I would appreciate early feedback on:
OpticOnce the structure is validated, I will clean up the implementation and prepare a final PR.