refactor(nano): Move the nano execution logic to a separate file #1535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bencher Report| Branch | refactor/nano-consensus-execution |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.94 m(+12.98%)Baseline: 1.72 m | 1.55 m (79.66%) | 2.06 m (94.15%) |
msbrogli
force-pushed
the
refactor/nano-consensus-execution
branch
2 times, most recently
from
6a6d233 to
b59c79a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1535 +/- ##
==========================================
+ Coverage 86.33% 86.35% +0.02%
==========================================
Files 437 439 +2
Lines 33645 33673 +28
Branches 5258 5260 +2
==========================================
+ Hits 29047 29078 +31
+ Misses 3594 3591 -3
Partials 1004 1004 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msbrogli
force-pushed
the
refactor/nano-consensus-execution
branch
from
b59c79a to
7362549
Compare
msbrogli
force-pushed
the
refactor/nano-consensus-execution
branch
from
7362549 to
0153848
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR moves the nano execution logic from the Block Consensus Algorithm to a separate file. This is a preparation for upcoming features such as block execution replay and block execution logging.
Acceptance Criteria
NCBlockExecutorto encapsulate nano execution logic.BlockConsensusAlgorithmintoNCBlockExecutor.BlockConsensusAlgorithm.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged