Open
Conversation
|
Bencher Report| Branch | feat/cli/run-in-shell |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.61 m(-5.98%)Baseline: 1.71 m | 1.54 m (95.72%) | 2.05 m (78.35%) |
jansegre
force-pushed
the
feat/cli/run-in-shell
branch
from
f1b5b76 to
28d508d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1552 +/- ##
==========================================
- Coverage 85.42% 85.34% -0.08%
==========================================
Files 464 464
Lines 31203 31203
Branches 4735 4735
==========================================
- Hits 26654 26631 -23
- Misses 3639 3656 +17
- Partials 910 916 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jansegre
force-pushed
the
feat/cli/run-in-shell
branch
2 times, most recently
from
f77b1f9 to
504e2d9
Compare
msbrogli
force-pushed
the
master
branch
2 times, most recently
from
eb416fa to
21d7909
Compare
jansegre
force-pushed
the
feat/cli/run-in-shell
branch
from
ffa5f04 to
45f5280
Compare
jansegre
force-pushed
the
feat/cli/run-in-shell
branch
from
45f5280 to
2eca25a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current support we have for using an "ipython shell" on a running node requires a non-trivial setup for a "remote ipython". It would be useful for testing to have a simple way to let the node "run in the background" in the
shellsubcommand.Acceptance Criteria
--x-run-nodeargument exclusively on theshellsubcommand, to enable the node to run in parallel to the shell, without affecting the prompt but still allowing it to work as expectedChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged