chore(nano): remove deprecated attribute from API #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bencher Report| Branch | chore/remove-deprecated |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.69 m(-1.78%)Baseline: 1.72 m | 1.55 m (91.63%) | 2.06 m (81.85%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1559 +/- ##
==========================================
- Coverage 86.34% 86.29% -0.06%
==========================================
Files 437 437
Lines 33610 33609 -1
Branches 5248 5248
==========================================
- Hits 29020 29002 -18
- Misses 3588 3600 +12
- Partials 1002 1007 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
force-pushed
the
chore/remove-deprecated
branch
from
a4e93f8 to
f86aef5
Compare
jansegre
approved these changes
Jan 21, 2026
msbrogli
approved these changes
Jan 21, 2026
github-project-automation
bot
moved this from In Progress (Done)
to In Review (WIP)
in Hathor Network
Contributor
Author
|
Do not merge until all clients are updated. Skip the next release. |
glevco
force-pushed
the
chore/remove-deprecated
branch
from
f86aef5 to
8ab07a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Remove deprecated attribute from blueprints API.
Acceptance Criteria
private_methodsfrom blueprints API.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged