chore(nano): remove deprecated attribute from API#1559
Merged
Conversation
|
Bencher Report| Branch | chore/remove-deprecated |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.60 m(-6.28%)Baseline: 1.71 m | 1.53 m (96.03%) | 2.05 m (78.10%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1559 +/- ##
==========================================
- Coverage 85.26% 85.17% -0.10%
==========================================
Files 464 464
Lines 30500 30499 -1
Branches 4620 4620
==========================================
- Hits 26006 25977 -29
- Misses 3606 3625 +19
- Partials 888 897 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
force-pushed
the
chore/remove-deprecated
branch
from
a4e93f8 to
f86aef5
Compare
jansegre
approved these changes
Jan 21, 2026
msbrogli
approved these changes
Jan 21, 2026
github-project-automation
bot
moved this from In Progress (Done)
to In Review (WIP)
in Hathor Network
Contributor
Author
|
Do not merge until all clients are updated. Skip the next release. |
glevco
force-pushed
the
chore/remove-deprecated
branch
from
f86aef5 to
8ab07a6
Compare
glevco
force-pushed
the
chore/remove-deprecated
branch
from
8ab07a6 to
9d16fe2
Compare
msbrogli
force-pushed
the
master
branch
2 times, most recently
from
eb416fa to
21d7909
Compare
glevco
force-pushed
the
chore/remove-deprecated
branch
from
9d16fe2 to
9ec2d8b
Compare
glevco
force-pushed
the
chore/remove-deprecated
branch
from
9ec2d8b to
b57909c
Compare
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Remove deprecated attribute from blueprints API.
Acceptance Criteria
private_methodsfrom blueprints API.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged