refactor: wallet on_new_tx #1561
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
glevco
force-pushed
the
refactor/wallet-on-new-tx
branch
from
c66ad17 to
eaef7cd
Compare
glevco
force-pushed
the
refactor/wallet-on-new-tx
branch
from
eaef7cd to
e0a08c0
Compare
glevco
force-pushed
the
feat/critical-indexes
branch
from
452fd4a to
2199ef8
Compare
glevco
force-pushed
the
refactor/wallet-on-new-tx
branch
from
e0a08c0 to
38ae478
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1561 +/- ##
==========================================
- Coverage 86.29% 86.28% -0.02%
==========================================
Files 437 437
Lines 33642 33649 +7
Branches 5257 5257
==========================================
+ Hits 29031 29033 +2
- Misses 3602 3608 +6
+ Partials 1009 1008 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
force-pushed
the
refactor/wallet-on-new-tx
branch
from
38ae478 to
6fc3b8b
Compare
msbrogli
requested changes
Jan 21, 2026
|
|
||
| self._register_wallet(wallet) | ||
|
|
||
| def _register_wallet(self, wallet: BaseWallet | None) -> None: |
Member
There was a problem hiding this comment.
Shouldn't this registration be done elsewhere? Maybe at HathorManager or the builder?
Member
There was a problem hiding this comment.
This refactor will be very useful to create multiple wallets in tests.
| address = manager.wallet.get_unused_address(mark_as_used=False) | ||
|
|
||
| blocks = add_new_blocks(manager, settings.REWARD_SPEND_MIN_BLOCKS + 1) | ||
| blocks = add_new_blocks(manager, settings.REWARD_SPEND_MIN_BLOCKS + 1, advance_clock=1) |
Member
There was a problem hiding this comment.
Why not add advance_clock=1 by default in add_new_blocks()?
| self._tx_storage.save_transaction(vertex) | ||
| with non_critical_code(self._log): | ||
| self._tx_storage.indexes.add_to_non_critical_indexes(vertex) | ||
| self._pubsub.publish(HathorEvents.NETWORK_NEW_TX_PROCESSING, tx=vertex) |
Member
There was a problem hiding this comment.
Should we refactor all event publications from the consensus to the vertex handler? This would allow us to publish everything after the consensus has executed.
github-project-automation
bot
moved this from In Progress (Done)
to In Review (WIP)
in Hathor Network
glevco
force-pushed
the
feat/critical-indexes
branch
2 times, most recently
from
00e1894 to
945a67f
Compare
glevco
force-pushed
the
refactor/wallet-on-new-tx
branch
from
6fc3b8b to
6bf9bd3
Compare
|
Bencher Report| Branch | refactor/wallet-on-new-tx |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.68 m(-2.29%)Baseline: 1.72 m | 1.55 m (92.11%) | 2.06 m (81.43%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1547
Motivation
There's a long-standing TODO on the
VertexHandlerto make the wallet processing of new txs asynchronous, via PubSub. This PR does this. I had to introduce a new event type to fire before the consensus, because the wallet expected itson_new_txmethod to be called before all other asynchronous events the consensus emits.Acceptance Criteria
NETWORK_NEW_TX_PROCESSING.walleton theVertexHandlerso it handlesNETWORK_NEW_TX_PROCESSINGevents asynchronously, instead of a synchronous call towallet.on_new_tx().Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged