Open
Conversation
msbrogli
approved these changes
Jan 27, 2026
|
Bencher Report| Branch | refactor/remove-noop-code |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.57 m(-7.87%)Baseline: 1.71 m | 1.54 m (97.69%) | 2.05 m (76.78%) |
jansegre
force-pushed
the
refactor/remove-noop-code
branch
from
ccefd5f to
a198839
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1578 +/- ##
==========================================
- Coverage 85.42% 85.34% -0.08%
==========================================
Files 464 464
Lines 31203 31196 -7
Branches 4735 4732 -3
==========================================
- Hits 26654 26625 -29
- Misses 3639 3657 +18
- Partials 910 914 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jansegre
force-pushed
the
refactor/remove-noop-code
branch
from
a198839 to
796e015
Compare
msbrogli
force-pushed
the
master
branch
2 times, most recently
from
eb416fa to
21d7909
Compare
jansegre
force-pushed
the
refactor/remove-noop-code
branch
from
796e015 to
df66905
Compare
jansegre
force-pushed
the
refactor/remove-noop-code
branch
from
df66905 to
7d19bb9
Compare
glevco
requested changes
Mar 19, 2026
Contributor
There was a problem hiding this comment.
I'm ready to approve this, but before, @msbrogli can you take a look at this comment?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This code has been found to be no-op and non-essential.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged