Merged
Conversation
|
| Branch | feat/hathorlib-blueprint-move-5 |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.61 m(-5.48%)Baseline: 1.71 m | 1.54 m (95.21%) | 2.05 m (78.77%) |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1620 +/- ##
==========================================
- Coverage 85.42% 85.15% -0.27%
==========================================
Files 464 464
Lines 31203 30439 -764
Branches 4735 4612 -123
==========================================
- Hits 26654 25920 -734
+ Misses 3639 3624 -15
+ Partials 910 895 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msbrogli
previously approved these changes
Mar 17, 2026
msbrogli
reviewed
Mar 17, 2026
jansegre
previously approved these changes
Mar 17, 2026
…print-move-5 * origin/master: feat(nano): add Nano Runtime V2 feature (#1623)
jansegre
previously approved these changes
Mar 19, 2026
msbrogli
previously approved these changes
Mar 20, 2026
msbrogli
approved these changes
Mar 20, 2026
jansegre
approved these changes
Mar 20, 2026
r4mmer
added a commit
that referenced
this pull request
Mar 27, 2026
Mark PR 6 as IMPLEMENTED (merged as #1620). Mark PRs 7 and 8 as IMPLEMENTED (merged together in this branch). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
To be able to implement the blueprint simulator on hathorlib there is a significant amount of code that needs to be moved from
hathor/tohathorlib/.Since moving this amount of code can cause instabilities we are breaking down these changes into more manageable and reviewable PRs.
This is the fifth PR in this sequence.
Acceptance Criteria
Move Blueprint core, context, method parsing, and accessors to hathorlib.
Changes of note:
is_nc_public_method,is_nc_view_method,is_nc_fallback_methodContext.create_from_vertexclassmethod was moved to separate utilitycreate_context_from_vertexcreate_from_*classmethods were converted into standalone factory methods (e.g. create_vertex_data_from_vertex, create_block_data_from_block, etc.)TxVersionwas unified on hathorlib so it can be used in nanocontracts dataclasses.Changes of note
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged