Skip to content

refactor(nano): implement BlueprintService#1624

Merged
glevco merged 1 commit intomasterfrom
refactor/nano/blueprint-service
Mar 25, 2026
Merged

refactor(nano): implement BlueprintService#1624
glevco merged 1 commit intomasterfrom
refactor/nano/blueprint-service

Conversation

@glevco
Copy link
Copy Markdown
Contributor

@glevco glevco commented Mar 18, 2026

Motivation

In preparation for new features, the Blueprint-related methods in the TransactionStorage will need access to the FeatureService. Instead of threading that service through methods, this PR refactors those methods to a standalone BlueprintService which has the FeatureService dependency.

Acceptance Criteria

  • Move Blueprint-related methods from the TransactionStorage to the new BlueprintService.
  • Improve NCBlueprintCatalog so blueprints are registered on an existing catalog, instead of having to replace the catalog itself.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Mar 18, 2026
@glevco glevco moved this from Todo to In Progress (WIP) in Hathor Network Mar 18, 2026
@glevco glevco force-pushed the refactor/nano/blueprint-service branch from a3e2936 to 3bac0a7 Compare March 18, 2026 16:37
Base automatically changed from feat/nano/runtime-v2 to master March 18, 2026 16:52
@glevco glevco force-pushed the refactor/nano/blueprint-service branch 4 times, most recently from 0806806 to 60abf0f Compare March 18, 2026 17:02
@glevco glevco moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Mar 18, 2026
@glevco glevco force-pushed the refactor/nano/blueprint-service branch 2 times, most recently from f6f11aa to 8ae496a Compare March 18, 2026 17:22
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2026

🐰 Bencher Report

Branchrefactor/nano/blueprint-service
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.56 m
(-8.33%)Baseline: 1.71 m
1.54 m
(98.18%)
2.05 m
(76.39%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 92.80000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.20%. Comparing base (0dd9dfa) to head (b40279d).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
hathor/dag_builder/cli.py 0.00% 4 Missing ⚠️
hathor/nanocontracts/catalog.py 82.60% 2 Missing and 2 partials ⚠️
hathor/nanocontracts/resources/nc_creation.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1624      +/-   ##
==========================================
+ Coverage   85.17%   85.20%   +0.02%     
==========================================
  Files         464      464              
  Lines       30446    30492      +46     
  Branches     4613     4618       +5     
==========================================
+ Hits        25933    25981      +48     
+ Misses       3621     3619       -2     
  Partials      892      892              
Flag Coverage Δ
test-lib 85.20% <92.80%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jansegre
jansegre previously approved these changes Mar 19, 2026
@jansegre jansegre moved this from In Progress (Done) to In Review (WIP) in Hathor Network Mar 19, 2026
@glevco glevco force-pushed the refactor/nano/blueprint-service branch from 8ae496a to e3446ae Compare March 24, 2026 15:33
@glevco glevco force-pushed the refactor/nano/blueprint-service branch 2 times, most recently from ed84076 to 0401fb3 Compare March 25, 2026 19:19
@glevco glevco force-pushed the refactor/nano/blueprint-service branch from 0401fb3 to b40279d Compare March 25, 2026 20:24
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Mar 25, 2026
@github-project-automation github-project-automation bot moved this from In Review (Done) to In Review (WIP) in Hathor Network Mar 25, 2026
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Mar 25, 2026
@glevco glevco merged commit 213a42e into master Mar 25, 2026
31 of 33 checks passed
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Mar 25, 2026
@glevco glevco deleted the refactor/nano/blueprint-service branch March 25, 2026 21:04
r4mmer added a commit that referenced this pull request Mar 27, 2026
* origin/master:
  refactor(nano): implement BlueprintService (#1624)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Waiting to be deployed

Development

Successfully merging this pull request may close these issues.

3 participants