refactor(nano): implement BlueprintService#1624
Merged
Conversation
a3e2936 to
3bac0a7
Compare
0806806 to
60abf0f
Compare
f6f11aa to
8ae496a
Compare
|
| Branch | refactor/nano/blueprint-service |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.56 m(-8.33%)Baseline: 1.71 m | 1.54 m (98.18%) | 2.05 m (76.39%) |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1624 +/- ##
==========================================
+ Coverage 85.17% 85.20% +0.02%
==========================================
Files 464 464
Lines 30446 30492 +46
Branches 4613 4618 +5
==========================================
+ Hits 25933 25981 +48
+ Misses 3621 3619 -2
Partials 892 892
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
jansegre
previously approved these changes
Mar 19, 2026
8ae496a to
e3446ae
Compare
ed84076 to
0401fb3
Compare
0401fb3 to
b40279d
Compare
msbrogli
approved these changes
Mar 25, 2026
jansegre
approved these changes
Mar 25, 2026
r4mmer
added a commit
that referenced
this pull request
Mar 27, 2026
* origin/master: refactor(nano): implement BlueprintService (#1624)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In preparation for new features, the Blueprint-related methods in the
TransactionStoragewill need access to theFeatureService. Instead of threading that service through methods, this PR refactors those methods to a standaloneBlueprintServicewhich has theFeatureServicedependency.Acceptance Criteria
TransactionStorageto the newBlueprintService.NCBlueprintCatalogso blueprints are registered on an existing catalog, instead of having to replace the catalog itself.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged