feat: Allow advanced routing patterns with RabbitMQ plugin#531
Merged
feat: Allow advanced routing patterns with RabbitMQ plugin#531
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #531 +/- ##
==========================================
+ Coverage 88.05% 90.28% +2.22%
==========================================
Files 54 54
Lines 2345 2358 +13
Branches 439 446 +7
==========================================
+ Hits 2065 2129 +64
+ Misses 256 213 -43
+ Partials 24 16 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
r4mmer
reviewed
Mar 19, 2025
2774a74 to
8024876
Compare
r4mmer
previously approved these changes
Mar 21, 2025
tuliomir
previously approved these changes
Mar 25, 2025
e3f4eb2 to
62c99f1
Compare
tuliomir
approved these changes
Apr 7, 2025
r4mmer
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
The RabbitMQ plugin should allow usage of advanced routing patterns in RabbitMQ.
For this, it should accept 2 new arguments: the exchange name and routing key, and validate whether either an exchange or a queue is provided, not both.
Previously it only supported sending to a single queue, which prevented developers from using it to send messages to Exchanges, which are needed for some more advanced routing strategies (see https://www.rabbitmq.com/tutorials/amqp-concepts#exchanges)
Security Checklist