Skip to content

feat: Allow advanced routing patterns with RabbitMQ plugin#531

Merged
luislhl merged 5 commits intomasterfrom
feat/rabbit-mq-plugin-advanced-routing
Apr 8, 2025
Merged

feat: Allow advanced routing patterns with RabbitMQ plugin#531
luislhl merged 5 commits intomasterfrom
feat/rabbit-mq-plugin-advanced-routing

Conversation

@luislhl
Copy link
Contributor

@luislhl luislhl commented Mar 10, 2025

Acceptance Criteria

The RabbitMQ plugin should allow usage of advanced routing patterns in RabbitMQ.

For this, it should accept 2 new arguments: the exchange name and routing key, and validate whether either an exchange or a queue is provided, not both.

Previously it only supported sending to a single queue, which prevented developers from using it to send messages to Exchanges, which are needed for some more advanced routing strategies (see https://www.rabbitmq.com/tutorials/amqp-concepts#exchanges)

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@luislhl luislhl requested a review from pedroferreira1 as a code owner March 10, 2025 15:11
@luislhl luislhl self-assigned this Mar 10, 2025
@luislhl luislhl requested a review from r4mmer March 10, 2025 15:11
@luislhl luislhl moved this from Todo to In Progress (Done) in Hathor Network Mar 10, 2025
@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.28%. Comparing base (33a03ed) to head (62c99f1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
+ Coverage   88.05%   90.28%   +2.22%     
==========================================
  Files          54       54              
  Lines        2345     2358      +13     
  Branches      439      446       +7     
==========================================
+ Hits         2065     2129      +64     
+ Misses        256      213      -43     
+ Partials       24       16       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@luislhl luislhl removed the request for review from pedroferreira1 March 11, 2025 16:37
@r4mmer r4mmer moved this from In Progress (Done) to In Review (WIP) in Hathor Network Mar 19, 2025
@luislhl luislhl force-pushed the feat/rabbit-mq-plugin-advanced-routing branch 2 times, most recently from 2774a74 to 8024876 Compare March 21, 2025 16:20
r4mmer
r4mmer previously approved these changes Mar 21, 2025
@luislhl luislhl requested a review from tuliomir March 24, 2025 18:32
tuliomir
tuliomir previously approved these changes Mar 25, 2025
@tuliomir tuliomir moved this from In Review (WIP) to In Review (Done) in Hathor Network Mar 25, 2025
@luislhl luislhl dismissed stale reviews from tuliomir and r4mmer via 0301b03 March 28, 2025 01:50
@luislhl luislhl moved this from In Review (Done) to In Progress (Done) in Hathor Network Mar 28, 2025
@luislhl luislhl requested review from r4mmer and tuliomir March 28, 2025 01:51
@luislhl luislhl force-pushed the feat/rabbit-mq-plugin-advanced-routing branch from e3f4eb2 to 62c99f1 Compare March 28, 2025 15:03
@tuliomir tuliomir moved this from In Progress (Done) to In Review (WIP) in Hathor Network Apr 7, 2025
@luislhl luislhl merged commit 08f2f0e into master Apr 8, 2025
8 of 9 checks passed
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Apr 8, 2025
@luislhl luislhl deleted the feat/rabbit-mq-plugin-advanced-routing branch April 8, 2025 16:37
@luislhl luislhl moved this from Waiting to be deployed to Done in Hathor Network Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants