chore: Upgrades bitcore-lib
#658
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #658 +/- ##
===========================================
+ Coverage 62.55% 79.67% +17.12%
===========================================
Files 77 77
Lines 5846 5846
Branches 1227 1214 -13
===========================================
+ Hits 3657 4658 +1001
+ Misses 2093 1171 -922
+ Partials 96 17 -79 ☔ View full report in Codecov by Sentry. |
tuliomir
requested review from
andreabadesso,
pedroferreira1 and
r4mmer
and removed request for
andreabadesso and
pedroferreira1
r4mmer
approved these changes
Jun 5, 2024
Contributor
Author
|
This upgrade will wait for a next stage of the LavaMoat implementation on our clients. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
bitcore-libandbitcore-mnemonicfrom8.25.10to10.0.36Notes
Both the release notes, and the changelog file do not have any information about the major upgrades 9 and 10.
There is no v9 tag, and the v10 tag has no information about breaking changes. The only source of information to understand the changes are the commits themselves and they indicate no breaking changes.
Tests sending transactions and validating addresses were executed on the Desktop Wallet to ensure the client applications worked correctly and passed with no issues.
Security Checklist