Skip to content

Conversation

@r4mmer
Copy link
Member

@r4mmer r4mmer commented Jul 16, 2025

Acceptance Criteria

Create a single address policy so the wallet facade can work in a single address mode.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@r4mmer r4mmer self-assigned this Jul 16, 2025
@r4mmer r4mmer requested a review from pedroferreira1 as a code owner July 16, 2025 16:43
@r4mmer r4mmer moved this from Todo to In Progress (WIP) in Hathor Network Jul 16, 2025
@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.97%. Comparing base (21ba6c1) to head (4dd2370).

Files with missing lines Patch % Lines
src/wallet/wallet.ts 37.50% 5 Missing ⚠️
src/utils/storage.ts 75.00% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (62.50%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
- Coverage   85.00%   84.97%   -0.04%     
==========================================
  Files         113      113              
  Lines        8389     8404      +15     
  Branches     1832     1847      +15     
==========================================
+ Hits         7131     7141      +10     
- Misses       1229     1233       +4     
- Partials       29       30       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@r4mmer r4mmer moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Jul 17, 2025
r4mmer added 8 commits July 17, 2025 13:24
…-policy

* origin/master: (31 commits)
  feat: fee token creation (#858)
  fix: checkAddressMine was crashing when called with an empty array (#977)
  feat: the nano amount field should accept 0
  Merge pull request #975 from HathorNetwork/chore/bump-v2.11.0
  feat: add nano execution logs API (#973)
  Refactor: Fullnode facade to Typescript (#972)
  Merge pull request #970 from HathorNetwork/chore/bump-v2.10.0
  fix: added missing tx proposal delete schema (#969)
  feat: add missing api calls for graphviz and nano (#967)
  Merge pull request #965 from HathorNetwork/feat/complete-token-info-object
  chore: bump package to v2.9.1 (#962)
  feat: catch and store async promise error (#960)
  chore: bump wallet lib to v2.9.0 (#958)
  tests: use core v0.67.0 docker image for the integration tests (#956)
  tests: update integration tests blueprints for the new core sdk (#954)
  fix: added a minimal accessData so methods that need storage don't crash (#955)
  feat: fee header (#951)
  feat: added read-only start (#950)
  fix: dont add metadata changed for voided txs (#948)
  test: Wallet Service infrastructure (#909)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress (Done)

Development

Successfully merging this pull request may close these issues.

2 participants