feat: fee token in tx template #964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raul-oliveira
force-pushed
the
raul-oliveira/fee-token-creation-tx-template
branch
from
fda016a to
dcee210
Compare
raul-oliveira
force-pushed
the
raul-oliveira/fee-token-creation
branch
6 times, most recently
from
727fbcb to
ab8cdcf
Compare
raul-oliveira
force-pushed
the
raul-oliveira/fee-token-creation
branch
from
ab8cdcf to
a9d458a
Compare
raul-oliveira
force-pushed
the
raul-oliveira/fee-token-creation-tx-template
branch
from
b0c3c18 to
ca29709
Compare
raul-oliveira
moved this from In Progress (WIP)
to In Progress (Done)
in Hathor Network
raul-oliveira
force-pushed
the
raul-oliveira/fee-token-creation
branch
from
578d9ba to
c23972a
Compare
raul-oliveira
force-pushed
the
raul-oliveira/fee-token-creation
branch
2 times, most recently
from
55ff9ca to
dfddf95
Compare
raul-oliveira
force-pushed
the
raul-oliveira/fee-token-creation-tx-template
branch
from
ca29709 to
60733a2
Compare
github-project-automation
bot
moved this from In Progress (Done)
to Waiting to be deployed
in Hathor Network
raul-oliveira
force-pushed
the
raul-oliveira/fee-token-creation-tx-template
branch
2 times, most recently
from
825e5cb to
23e3b23
Compare
raul-oliveira
force-pushed
the
raul-oliveira/fee-token-creation-tx-template
branch
from
01a56f5 to
29238ac
Compare
r4mmer
previously approved these changes
Jan 9, 2026
pedroferreira1
previously approved these changes
Jan 9, 2026
raul-oliveira
force-pushed
the
raul-oliveira/fee-token-creation-tx-template
branch
2 times, most recently
from
73dffe2 to
fb8aefc
Compare
raul-oliveira
dismissed stale reviews from pedroferreira1 and r4mmer
via
4a37863
raul-oliveira
force-pushed
the
raul-oliveira/fee-token-creation-tx-template
branch
2 times, most recently
from
4a37863 to
1db9f33
Compare
raul-oliveira
force-pushed
the
raul-oliveira/fee-token-creation-tx-template
branch
from
1db9f33 to
0cc6faf
Compare
tuliomir
previously approved these changes
Jan 15, 2026
Comment on lines
+417
to
+421
| tokenInfo: { | ||
| name: 'Hathor', | ||
| symbol: 'HTR', | ||
| version: TokenVersion.NATIVE, | ||
| }, |
Contributor
There was a problem hiding this comment.
chore: Use the constants instead of hardcoding this data.
Suggested change
| tokenInfo: { | |
| name: 'Hathor', | |
| symbol: 'HTR', | |
| version: TokenVersion.NATIVE, | |
| }, | |
| tokenInfo: constants.DEFAULT_NATIVE_TOKEN_CONFIG, |
| private static buildFeeHeader(ctx: TxTemplateContext): FeeHeader { | ||
| const entries: IFeeEntry[] = Array.from(ctx.fees.entries()).map(([tokenUid, amount]) => ({ | ||
| tokenIndex: tokensUtils.getTokenIndex( | ||
| ctx.tokens.map(t => ({ uid: t })), |
Contributor
There was a problem hiding this comment.
question: There is a warning that this header section wasn't tested. Isn't this a critical part of the resulting transaction, or can we skip this testing to a later stage?
Contributor
Author
There was a problem hiding this comment.
Nice catch. We are using the fee header in the integration tests. I'll see why it's nove flagging as covered :)
pedroferreira1
previously approved these changes
Jan 15, 2026
raul-oliveira
dismissed stale reviews from pedroferreira1 and tuliomir
via
9c9a28d
raul-oliveira
force-pushed
the
raul-oliveira/fee-token-creation-tx-template
branch
from
9c9a28d to
4683ca0
Compare
pedroferreira1
approved these changes
Jan 16, 2026
tuliomir
approved these changes
Jan 16, 2026
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #858
Motivation
Add the fee, and fee completion api to the transaction template. It will enable developers to create custom transactions without having to add new methods or args to the wallet facade
Acceptance Criteria
addFeeinstruction, and executorSecurity Checklist