-
Notifications
You must be signed in to change notification settings - Fork 14
docs: Fullnode Typings [5] - Utxo management #987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| inputs.push({ | ||
| txId: utxo.tx_id, | ||
| index: utxo.index, | ||
| token: tokenUid, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: token is now a mandatory property for Inputs and Outputs, so I had to add it here.
While the code handles perfectly the token being absent, the new types do not allow it.
14ad290 to
29d11c4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #987 +/- ##
==========================================
+ Coverage 86.59% 86.61% +0.01%
==========================================
Files 113 113
Lines 8400 8402 +2
Branches 1852 1858 +6
==========================================
+ Hits 7274 7277 +3
Misses 1097 1097
+ Partials 29 28 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| value: 10n, | ||
| authorities: 0n, | ||
| timelock: null, | ||
| height: null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit polemic: we needed to modify the return properties for getUtxosForAmount to respect the IUtxo type interface.
The height and token properties were added. type will be needed anyway for the new fee tokens.
Acceptance Criteria
Security Checklist