Skip to content

Conversation

@tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Jan 2, 2026

Acceptance Criteria

  • Adds typings to the Signatures methods

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir self-assigned this Jan 2, 2026
@tuliomir tuliomir moved this from Todo to In Progress (WIP) in Hathor Network Jan 2, 2026
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.79%. Comparing base (1a929ba) to head (d5c0235).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #988      +/-   ##
==========================================
- Coverage   86.81%   86.79%   -0.02%     
==========================================
  Files         113      113              
  Lines        8507     8507              
  Branches     1884     1876       -8     
==========================================
- Hits         7385     7384       -1     
- Misses       1094     1095       +1     
  Partials       28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tuliomir tuliomir moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Jan 2, 2026
@tuliomir tuliomir requested review from andreabadesso and removed request for r4mmer January 12, 2026 23:03
andreabadesso
andreabadesso previously approved these changes Jan 14, 2026
@tuliomir tuliomir moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jan 14, 2026
raul-oliveira
raul-oliveira previously approved these changes Jan 16, 2026
Copy link
Contributor

@raul-oliveira raul-oliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. IMO we can have a type to simplify

@tuliomir tuliomir dismissed stale reviews from raul-oliveira and andreabadesso via 5d3e294 January 16, 2026 14:20
@tuliomir tuliomir merged commit c61ab10 into master Jan 19, 2026
5 checks passed
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Jan 19, 2026
@tuliomir tuliomir deleted the chore/types-sign branch January 19, 2026 16:33
@tuliomir tuliomir moved this from Waiting to be deployed to Done in Hathor Network Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants