fix: prevent token tx history screen from fetching duplicated request and showing duplicated txs#832
Merged
pedroferreira1 merged 2 commits intomasterfrom Jan 28, 2026
Merged
Conversation
… and showing duplicated txs
pedroferreira1
commented
Jan 28, 2026
Comment on lines
+892
to
+898
| const existingData = get(state.tokensHistory, `${token}.data`, []); | ||
|
|
||
| // Create a Set of existing txIds for efficient lookup | ||
| const existingTxIds = new Set(existingData.map((tx) => tx.txId)); | ||
|
|
||
| // Filter out any transactions that already exist to prevent duplicates | ||
| const uniqueNewHistory = newHistory.filter((tx) => !existingTxIds.has(tx.txId)); |
Member
Author
There was a problem hiding this comment.
There's still one race condition that I couldn't find, so I decided to go with the deduplication code. With this code I could've removed the other part, this would already prevent showing duplicated txs but the rest of the code is also an improvement.
andreabadesso
approved these changes
Jan 28, 2026
tuliomir
approved these changes
Jan 28, 2026
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria