Fix missing System.Drawing assembly reference #218

HavenDV · 2025-11-29T17:32:04Z

Added System.Drawing.Common 10.0.0 package reference to all platform projects that compile shared System.Drawing source files. This fixes the IImage type reference error in GeneratedIconSource.System.Drawing.cs for .NET 10 target frameworks.

Projects updated:

H.NotifyIcon.Wpf (net10.0-windows)
H.NotifyIcon.WinUI (net10.0-windows10.0.17763.0)
H.NotifyIcon.Uno (net10.0)
H.NotifyIcon.Uno.WinUI (net10.0, net10.0-windows10.0.19041)
H.NotifyIcon.Maui (net10.0, net10.0-windows10.0.19041.0)

Resolves: Assembly reference to System.Private.Windows.GdiPlus

Summary by CodeRabbit

Chores
- Added System.Drawing.Common dependency support for .NET 10.0 builds across platform-specific libraries to ensure compatibility with the latest framework version.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Added System.Drawing.Common 10.0.0 package reference to all platform projects that compile shared System.Drawing source files. This fixes the IImage type reference error in GeneratedIconSource.System.Drawing.cs for .NET 10 target frameworks. Projects updated: - H.NotifyIcon.Wpf (net10.0-windows) - H.NotifyIcon.WinUI (net10.0-windows10.0.17763.0) - H.NotifyIcon.Uno (net10.0) - H.NotifyIcon.Uno.WinUI (net10.0, net10.0-windows10.0.19041) - H.NotifyIcon.Maui (net10.0, net10.0-windows10.0.19041.0) Resolves: Assembly reference to System.Private.Windows.GdiPlus

coderabbitai · 2025-11-29T17:32:13Z

Walkthrough

Conditional PackageReference entries for System.Drawing.Common (version 10.0.0) are added to five project files (Maui, Uno.WinUI, Uno, WinUI, and Wpf), each targeting specific .NET 10.0 framework variants without altering functional code or public APIs.

Changes

Cohort / File(s)	Change Summary
System.Drawing.Common Dependency Additions `src/libs/H.NotifyIcon.Maui/H.NotifyIcon.Maui.csproj`, `src/libs/H.NotifyIcon.Uno.WinUI/H.NotifyIcon.Uno.WinUI.csproj`, `src/libs/H.NotifyIcon.Uno/H.NotifyIcon.Uno.csproj`, `src/libs/H.NotifyIcon.WinUI/H.NotifyIcon.WinUI.csproj`, `src/libs/H.NotifyIcon.Wpf/H.NotifyIcon.Wpf.csproj`	Conditional PackageReference for System.Drawing.Common v10.0.0 added to each project with framework-specific conditions (net10.0, net10.0-windows variants)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Verify System.Drawing.Common v10.0.0 compatibility with each target framework condition
Confirm no version conflicts with existing dependencies across projects

Poem

🐰 A drawing brush we now procure,
For dot-net ten, so fresh and pure!
Each framework gets its rightful share,
Common colors everywhere! 🎨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fix missing System.Drawing assembly reference' directly and clearly describes the main change: adding System.Drawing.Common package references to resolve assembly reference errors in .NET 10 target frameworks.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch claude/fix-drawing-assembly-ref-01JirDb1pD15DULCmqcfm7WY

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 27507ca and 618f8c6.

📒 Files selected for processing (5)

src/libs/H.NotifyIcon.Maui/H.NotifyIcon.Maui.csproj (1 hunks)
src/libs/H.NotifyIcon.Uno.WinUI/H.NotifyIcon.Uno.WinUI.csproj (1 hunks)
src/libs/H.NotifyIcon.Uno/H.NotifyIcon.Uno.csproj (1 hunks)
src/libs/H.NotifyIcon.WinUI/H.NotifyIcon.WinUI.csproj (1 hunks)
src/libs/H.NotifyIcon.Wpf/H.NotifyIcon.Wpf.csproj (1 hunks)

🧰 Additional context used

🧠 Learnings (13)

📓 Common learnings

Learnt from: CR
Repo: HavenDV/H.NotifyIcon PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-10-23T11:04:44.417Z
Learning: Applies to src/libs/{H.GeneratedIcons.System.Drawing,H.GeneratedIcons.SkiaSharp}/**/*.cs : When modifying icon generation, update both System.Drawing and SkiaSharp implementations to maintain feature parity

Learnt from: CR
Repo: HavenDV/H.NotifyIcon PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-10-23T11:04:44.417Z
Learning: Applies to src/libs/H.NotifyIcon.Shared/**/*.{Wpf,WinUI,WinRT}.cs : Use platform-specific filename suffixes .Wpf.cs, .WinUI.cs, .WinRT.cs for platform-specific implementations in the Shared project

Learnt from: CR
Repo: HavenDV/H.NotifyIcon PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-10-23T11:04:44.417Z
Learning: Applies to src/libs/Directory.Build.props : Configure GraphicsLibrary (System.Drawing or SkiaSharp) in src/libs/Directory.Build.props and map to HAS_SYSTEM_DRAWING or HAS_SKIA_SHARP defines

Learnt from: CR
Repo: HavenDV/H.NotifyIcon PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-10-23T11:04:44.417Z
Learning: Applies to src/libs/H.NotifyIcon/** : Use CsWin32-generated P/Invoke for Windows interop (Shell_NotifyIcon and NOTIFYICONDATA) instead of handwritten signatures

Learnt from: CR
Repo: HavenDV/H.NotifyIcon PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-10-23T11:04:44.417Z
Learning: Applies to src/libs/H.NotifyIcon.Shared/**/*.cs : Place cross-platform shared code under src/libs/H.NotifyIcon.Shared/, organized by feature files (e.g., TaskbarIcon.cs, TaskbarIcon.Properties.cs, TaskbarIcon.ContextMenu.cs)

Learnt from: CR
Repo: HavenDV/H.NotifyIcon PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-10-23T11:04:44.417Z
Learning: Applies to src/libs/{H.NotifyIcon,H.NotifyIcon.Wpf,H.NotifyIcon.WinUI,H.NotifyIcon.Uno.WinUI,H.NotifyIcon.Maui,H.GeneratedIcons.System.Drawing,H.GeneratedIcons.SkiaSharp}/*.csproj : Sign library assemblies with src/libs/key.snk (SignAssembly true and AssemblyOriginatorKeyFile set)

Learnt from: CR
Repo: HavenDV/H.NotifyIcon PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-10-23T11:04:44.417Z
Learning: Applies to src/apps/**/*.csproj : Sample apps should target the platform-appropriate frameworks listed (e.g., WPF, WinUI, Console, MAUI) and remain buildable via dotnet run/build commands

Learnt from: CR
Repo: HavenDV/H.NotifyIcon PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-10-23T11:04:44.417Z
Learning: Applies to src/**/*.cs : Use conditional compilation symbols for platform code: HAS_WPF, HAS_WINUI, HAS_UNO, HAS_MAUI; and for graphics backends: HAS_SYSTEM_DRAWING, HAS_SKIA_SHARP

Learnt from: CR
Repo: HavenDV/H.NotifyIcon PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-10-23T11:04:44.417Z
Learning: Applies to tests/H.NotifyIcon.IntegrationTests/*.csproj : Maintain test target frameworks for Windows (e.g., net4.8 and net9.0-windows) in the integration test project