Add default values to FlxTextField constructor #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated constructor parameters to have default values for X, Y, and Width.
dtwotwo
reviewed
Jan 19, 2026
Member
|
Are you using this class is a project? |
Contributor
Author
I was thinking about maybe trying it but I just noticed that it didn't have default constructor values while the superclass did and thought it was a bit strange |
Member
|
I was thinking about deprecating this class, entirely. I don't think it has any uses, now |
Contributor
Author
|
Still, it is kinda strange that there aren't any default values |
Member
|
Not as strange as maintaining a class no one uses. I'm always afraid that updating these classes will make people think they're worth using. I might just deprecate all these old classes and see if anyone complains. If you do end up using it, let me know, since it tells me there's an issue with using FlxText |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated constructor parameters to have default values for X, Y, and Width.