FlxSound and FlxG.sound: Large refactor of sound initialization#3558
Merged
Geokureli merged 39 commits intoHaxeFlixel:devfrom Feb 24, 2026
Merged
FlxSound and FlxG.sound: Large refactor of sound initialization#3558Geokureli merged 39 commits intoHaxeFlixel:devfrom
Geokureli merged 39 commits intoHaxeFlixel:devfrom
Conversation
…ad* and play* methods
…pData, add logging to resolveBitmapData
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FlxSound
Add new chained setup system, I.E.:
Changes
setupmethod, to init playback fields likevolume,looped,loopUntil,autoDestroyandonCompleteload,loadStreamedandloadFromURLupdateProximity, update positional sounds when they move, rather than the next updateSoundFrontEndfull private access toFlxSoundFlxG.sound
Similar chained setup to work with FlxSound changes:
Changes:
playMusic, deprecating the old functionloadand loadStreamed for the newcreateandcreateStreamedFlxG.assets
canStreamSounddynamicaddSoundExtpublicFlxAssets
assertBitmapData,assertSoundandresolveSoundresolveBitmapData