Skip to content

Conversation

@yuxiaomao
Copy link
Collaborator

Currently downloaded hl binaries (Windows + make release) allows user to run with SDL but not with DX, this PR add required DX dlls

@tobil4sk
Copy link
Member

Should we also update the vcxproj files so they contain the include/dx library path?

Also, it doesn't have to be handled in this PR, but we could also download the dlls for cmake builds too, and tell cmake to look in include/dx. Not sure if it would work for mingw or not, since the release probably has msvc binaries.

Just about the title, I think it would be less confusing to refer to it as the visual studio build rather than the make build, because make is only used to package the binaries from visual studio.

@yuxiaomao
Copy link
Collaborator Author

I think update vcxproj isn't necessary, because the dlls aren't compile time dependences;
It could be useful to download for cmake builds but as there are already other dlls differences, e.g. SDL.dll, I didn't check on cmake

@yuxiaomao yuxiaomao changed the title [ci] add dxcompiler.dll, dxil.dll into windows make build [ci] add dxcompiler.dll, dxil.dll into windows VS build Dec 29, 2025
@yuxiaomao yuxiaomao merged commit 60724b4 into HaxeFoundation:master Dec 29, 2025
13 checks passed
@yuxiaomao yuxiaomao deleted the dev-ci-dxcompiler branch December 29, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants